You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@netbeans.apache.org by GitBox <gi...@apache.org> on 2018/11/17 07:29:26 UTC
[GitHub] dukescript commented on issue #917: Fragments for libs.javafx with
JavaFX 11 implementation
dukescript commented on issue #917: Fragments for libs.javafx with JavaFX 11 implementation
URL: https://github.com/apache/incubator-netbeans/pull/917#issuecomment-439595927
The change creates three new modules and puts them into `extra` cluster: `libs.javafx.linux`, `libs.javafx.macosx`, `libs.javafx.win`. These modules are wrappers around [OpenJFX](http://openjfx.io) maven JARs, however none of the modules contains the GPL licensed JARs by itself - it just references them and the plugin manager downloads them directly to the user when installing them.
As such it is important for the modules to not be present in the final ZIP and only available from an update center. Putting the modules into `extra` cluster manages the first part - they aren't in the ZIP. To make them available from an update center this change introduces a "local" update center that holds the (empty) NBM files. Ready for install at any time.
The changes were tested on JDK8 and JDK11. On JDK8 only `nb-javac` is downloaded. On JDK11 one can continue without downloading anything, or download both: the `nb-javac` as well as appropriate `openjfx` library.
Please review, approve, integrate. Thanks in advance @jlahoda, @sdedic, @svenreimers!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists