[GitHub] [spark] cloud-fan commented on a change in pull request #29961: [SPARK-33082][SQL] Remove hive-1.2 workaround code

[GitBox <gi...@apache.org>]

cloud-fan commented on a change in pull request #29961:
URL: https://github.com/apache/spark/pull/29961#discussion_r501173665



##########
File path: sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/orc/OrcSourceSuite.scala
##########
@@ -581,7 +580,7 @@ class OrcSourceSuite extends OrcSuite with SharedSparkSession {
   }
 
   test("Enforce direct encoding column-wise selectively") {
-    testSelectiveDictionaryEncoding(isSelective = true)
+    testSelectiveDictionaryEncoding(isSelective = true, isHive23 = false)

Review comment:
       why `isHive23` is false here?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org