You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@commons.apache.org by GitBox <gi...@apache.org> on 2018/12/19 21:56:01 UTC
[GitHub] asciborek commented on a change in pull request #392: LANG-1410:
eliminate one unnecessary local int variable and add more tests
asciborek commented on a change in pull request #392: LANG-1410: eliminate one unnecessary local int variable and add more tests
URL: https://github.com/apache/commons-lang/pull/392#discussion_r243089452
##########
File path: src/main/java/org/apache/commons/lang3/StringUtils.java
##########
@@ -338,15 +338,17 @@ public static boolean isAllEmpty(final CharSequence... css) {
* @since 3.0 Changed signature from isBlank(String) to isBlank(CharSequence)
*/
public static boolean isBlank(final CharSequence cs) {
- int strLen;
Review comment:
So maybe instead of "sz" the name should be "i" or "index"? It's quite good name for a looping-control variable, isn't?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services