[GitHub] [airflow] eumiro commented on a diff in pull request #34223: Refactor: Simplify some loops

["eumiro (via GitHub)" <gi...@apache.org>]

eumiro commented on code in PR #34223:
URL: https://github.com/apache/airflow/pull/34223#discussion_r1323423005


##########
dev/assign_cherry_picked_prs_with_milestone.py:
##########
@@ -276,9 +275,7 @@ def assign_prs(
         console.print("\n[yellow]Implying --skip-assigned as summary report is enabled[/]\n")
         skip_assigned = True
     milestone = repo.get_milestone(milestone_number)
-    count_prs = len(prs)
-    if limit_pr_count:
-        count_prs = limit_pr_count
+    count_prs = limit_pr_count if limit_pr_count else None

Review Comment:
   `limit_pr_count` can be `None` and we want to print the `count_prs` anyway, so I changed it back to real `len(prs)` if `limit_pr_count is None`.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org