You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@couchdb.apache.org by nickva <gi...@git.apache.org> on 2015/10/16 20:12:06 UTC
[GitHub] couchdb-couch-replicator pull request: Fix race condition in waiti...
GitHub user nickva opened a pull request:
https://github.com/apache/couchdb-couch-replicator/pull/22
Fix race condition in waiting for compactor in eunit test.
Monitor waiting for replicator will sometimes fail with noproc
error, because there is a race condition between a running
compactor process and setting up its monitor and waiting on it.
This error appears about once or twice in a 100 runs.
It can be made to appear more often by tweaking 50 and 5 values in:
```
should_populate_and_compact(RepPid, Source, Target, 50, 5),
```
to something like 1, 20.
This commit fixes race condition by handling noproc.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/cloudant/couchdb-couch-replicator 2848-fix-rc-in-compact-tests
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/couchdb-couch-replicator/pull/22.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #22
----
commit 98dfccd76f127ff629ba430f2acc5e199480931b
Author: Nick Vatamaniuc <va...@gmail.com>
Date: 2015-10-16T18:05:40Z
Fix race condition in waiting for compactor in eunit test.
Monitor waiting for replicator will sometimes fail with noproc
error, because there is a race condition between a running
compactor process and setting up its monitor and waiting on it.
This error appears about once or twice in a 100 runs.
It can be made to appear more often by tweaking 50 and 5 values in:
```
should_populate_and_compact(RepPid, Source, Target, 50, 5),
```
to something like 1, 20.
This commit fixes race condition by handling noproc.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-couch-replicator pull request: Fix race condition in waiti...
Posted by rnewson <gi...@git.apache.org>.
Github user rnewson commented on the pull request:
https://github.com/apache/couchdb-couch-replicator/pull/22#issuecomment-148789422
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-couch-replicator pull request: Fix race condition in waiti...
Posted by kxepal <gi...@git.apache.org>.
Github user kxepal commented on the pull request:
https://github.com/apache/couchdb-couch-replicator/pull/22#issuecomment-148809145
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-couch-replicator pull request: Fix race condition in waiti...
Posted by kxepal <gi...@git.apache.org>.
Github user kxepal commented on a diff in the pull request:
https://github.com/apache/couchdb-couch-replicator/pull/22#discussion_r42273215
--- Diff: test/couch_replicator_compact_tests.erl ---
@@ -284,11 +286,13 @@ wait_for_compaction(Type, Db) ->
case couch_db:wait_for_compaction(Db) of
ok ->
ok;
+ {error, noproc} ->
+ ok;
--- End diff --
But is this really ok?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-couch-replicator pull request: Fix race condition in waiti...
Posted by rnewson <gi...@git.apache.org>.
Github user rnewson commented on a diff in the pull request:
https://github.com/apache/couchdb-couch-replicator/pull/22#discussion_r42272797
--- Diff: test/couch_replicator_compact_tests.erl ---
@@ -284,11 +286,13 @@ wait_for_compaction(Type, Db) ->
case couch_db:wait_for_compaction(Db) of
ok ->
ok;
+ {error, noproc} ->
--- End diff --
hah!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-couch-replicator pull request: Fix race condition in waiti...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/couchdb-couch-replicator/pull/22
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---