You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@subversion.apache.org by kf...@apache.org on 2012/11/16 23:22:25 UTC

svn propchange: r873216 - svn:log

Author: kfogel
Revision: 873216
Modified property: svn:log

Modified: svn:log at Fri Nov 16 22:22:25 2012
------------------------------------------------------------------------------
--- svn:log (original)
+++ svn:log Fri Nov 16 22:22:25 2012
@@ -2,7 +2,7 @@ Merge r32790, r32796, r32798 from trunk:
 
  * r32790, r32796, r32798
    Fix issue #2505: make switch continue after deleting locally modified
-   directories, as it update and merge do.
+   directories, as update and merge do.
    Notes:
      r32796 updates the docstring.
      r32798 is an obvious fix.


Re: svn propchange: r873216 - svn:log

Posted by Daniel Shahaf <d....@daniel.shahaf.name>.
Karl Fogel wrote on Sat, Nov 17, 2012 at 16:31:08 -0600:
> Daniel Shahaf <d....@daniel.shahaf.name> writes:
> >FYI Karl: http://svn.apache.org/r1410697
> >:-)
> 
> Oh, thanks!  And here I thought I was all thorough because I managed to
> catch the original commit (r872864) as well as the merge commit
> (r873216)... but I didn't think to look in the regression tests.  Nice.
> 
> You might be amused by how I found the typo in the first place.
> 

Thanks for the extra background, I was curious about that.  And for the
fix. :) 

Re: svn propchange: r873216 - svn:log

Posted by Daniel Shahaf <d....@daniel.shahaf.name>.
Karl Fogel wrote on Sat, Nov 17, 2012 at 16:31:08 -0600:
> Daniel Shahaf <d....@daniel.shahaf.name> writes:
> >FYI Karl: http://svn.apache.org/r1410697
> >:-)
> 
> Oh, thanks!  And here I thought I was all thorough because I managed to
> catch the original commit (r872864) as well as the merge commit
> (r873216)... but I didn't think to look in the regression tests.  Nice.
> 
> You might be amused by how I found the typo in the first place.
> 

Thanks for the extra background, I was curious about that.  And for the
fix. :) 

Re: svn propchange: r873216 - svn:log

Posted by Karl Fogel <kf...@red-bean.com>.
Daniel Shahaf <d....@daniel.shahaf.name> writes:
>FYI Karl: http://svn.apache.org/r1410697
>:-)

Oh, thanks!  And here I thought I was all thorough because I managed to
catch the original commit (r872864) as well as the merge commit
(r873216)... but I didn't think to look in the regression tests.  Nice.

You might be amused by how I found the typo in the first place.

I've been reading "Version Control with Git, 2nd Edition" because I was
asked to write a review of it (for me, it was an excuse to finally learn
various bits of git I'd never really got down).  r873216 appears as an
example in in the section the Git<->SVN bridge.  The authors decided to
use an example commit from Subversion's own repository, but the log
message happened to have this typo, and I thought, gosh, I could fix
that :-).  So now the book looks like it has a misquote -- but I'm sure
like N people in the world would ever notice, for very low values of N,
and those people can easily figure out what happened.

-K

>kfogel@apache.org wrote on Fri, Nov 16, 2012 at 22:22:25 -0000:
>> Author: kfogel
>> Revision: 873216
>> Modified property: svn:log
>> 
>> Modified: svn:log at Fri Nov 16 22:22:25 2012
>> ------------------------------------------------------------------------------
>> --- svn:log (original)
>> +++ svn:log Fri Nov 16 22:22:25 2012
>> @@ -2,7 +2,7 @@ Merge r32790, r32796, r32798 from trunk:
>>  
>>   * r32790, r32796, r32798
>>     Fix issue #2505: make switch continue after deleting locally modified
>> -   directories, as it update and merge do.
>> +   directories, as update and merge do.
>>     Notes:
>>       r32796 updates the docstring.
>>       r32798 is an obvious fix.
>> 

Re: svn propchange: r873216 - svn:log

Posted by Karl Fogel <kf...@red-bean.com>.
Daniel Shahaf <d....@daniel.shahaf.name> writes:
>FYI Karl: http://svn.apache.org/r1410697
>:-)

Oh, thanks!  And here I thought I was all thorough because I managed to
catch the original commit (r872864) as well as the merge commit
(r873216)... but I didn't think to look in the regression tests.  Nice.

You might be amused by how I found the typo in the first place.

I've been reading "Version Control with Git, 2nd Edition" because I was
asked to write a review of it (for me, it was an excuse to finally learn
various bits of git I'd never really got down).  r873216 appears as an
example in in the section the Git<->SVN bridge.  The authors decided to
use an example commit from Subversion's own repository, but the log
message happened to have this typo, and I thought, gosh, I could fix
that :-).  So now the book looks like it has a misquote -- but I'm sure
like N people in the world would ever notice, for very low values of N,
and those people can easily figure out what happened.

-K

>kfogel@apache.org wrote on Fri, Nov 16, 2012 at 22:22:25 -0000:
>> Author: kfogel
>> Revision: 873216
>> Modified property: svn:log
>> 
>> Modified: svn:log at Fri Nov 16 22:22:25 2012
>> ------------------------------------------------------------------------------
>> --- svn:log (original)
>> +++ svn:log Fri Nov 16 22:22:25 2012
>> @@ -2,7 +2,7 @@ Merge r32790, r32796, r32798 from trunk:
>>  
>>   * r32790, r32796, r32798
>>     Fix issue #2505: make switch continue after deleting locally modified
>> -   directories, as it update and merge do.
>> +   directories, as update and merge do.
>>     Notes:
>>       r32796 updates the docstring.
>>       r32798 is an obvious fix.
>> 

Re: svn propchange: r873216 - svn:log

Posted by Daniel Shahaf <d....@daniel.shahaf.name>.
FYI Karl: http://svn.apache.org/r1410697
:-)

kfogel@apache.org wrote on Fri, Nov 16, 2012 at 22:22:25 -0000:
> Author: kfogel
> Revision: 873216
> Modified property: svn:log
> 
> Modified: svn:log at Fri Nov 16 22:22:25 2012
> ------------------------------------------------------------------------------
> --- svn:log (original)
> +++ svn:log Fri Nov 16 22:22:25 2012
> @@ -2,7 +2,7 @@ Merge r32790, r32796, r32798 from trunk:
>  
>   * r32790, r32796, r32798
>     Fix issue #2505: make switch continue after deleting locally modified
> -   directories, as it update and merge do.
> +   directories, as update and merge do.
>     Notes:
>       r32796 updates the docstring.
>       r32798 is an obvious fix.
> 

Re: svn propchange: r873216 - svn:log

Posted by Daniel Shahaf <d....@daniel.shahaf.name>.
FYI Karl: http://svn.apache.org/r1410697
:-)

kfogel@apache.org wrote on Fri, Nov 16, 2012 at 22:22:25 -0000:
> Author: kfogel
> Revision: 873216
> Modified property: svn:log
> 
> Modified: svn:log at Fri Nov 16 22:22:25 2012
> ------------------------------------------------------------------------------
> --- svn:log (original)
> +++ svn:log Fri Nov 16 22:22:25 2012
> @@ -2,7 +2,7 @@ Merge r32790, r32796, r32798 from trunk:
>  
>   * r32790, r32796, r32798
>     Fix issue #2505: make switch continue after deleting locally modified
> -   directories, as it update and merge do.
> +   directories, as update and merge do.
>     Notes:
>       r32796 updates the docstring.
>       r32798 is an obvious fix.
>