You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@kvrocks.apache.org by "git-hulk (via GitHub)" <gi...@apache.org> on 2024/11/16 05:26:34 UTC
[PR] Remove the detection of GOARCH and GOOS when building [kvrocks-controller]
git-hulk opened a new pull request, #218:
URL: https://github.com/apache/kvrocks-controller/pull/218
For most users, they don't need to have the cross-compilation,
and the script for detecting the OS and ARCH might be wrong in some niche operation systems.
So let's remove this and users can specify the GOOS/GOARCH environment explicitly if they want.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Remove the detection of GOARCH and GOOS when building [kvrocks-controller]
Posted by "git-hulk (via GitHub)" <gi...@apache.org>.
git-hulk merged PR #218:
URL: https://github.com/apache/kvrocks-controller/pull/218
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Remove the detection of GOARCH and GOOS when building [kvrocks-controller]
Posted by "PragmaTwice (via GitHub)" <gi...@apache.org>.
PragmaTwice commented on code in PR #218:
URL: https://github.com/apache/kvrocks-controller/pull/218#discussion_r1844920007
##########
scripts/build.sh:
##########
@@ -86,17 +32,9 @@ for TARGET_NAME in "$SERVER_TARGET_NAME" "$CLIENT_TARGET_NAME"; do
CMD_PATH="${GO_PROJECT}/cmd/client"
fi
- if [[ "$BUILDER_IMAGE" == "none" ]]; then
- GOOS="$TARGET_OS" GOARCH="$TARGET_ARCH" CGO_ENABLED=0 go build -v -ldflags \
- "-X $GO_PROJECT/version.Version=$VERSION" \
- -o ${TARGET_NAME} ${CMD_PATH}
- else
- docker run --rm --privileged -it -v $(pwd):/${TARGET_NAME} -w /${TARGET_NAME} \
- -e GOOS="$TARGET_OS" -e GOARCH="$TARGET_ARCH" -e CGO_ENABLED=0 \
- $BUILDER_IMAGE go build -v -ldflags \
- "-X $GO_PROJECT/version.Version=$VERSION" \
- -o /${TARGET_NAME}/${TARGET_NAME} ${CMD_PATH}
- fi
+ GOOS="$TARGET_OS" GOARCH="$TARGET_ARCH" CGO_ENABLED=0 go build -v -ldflags \
Review Comment:
seems TARGET_OS and TARGET_ARCH are undefined now
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Remove the detection of GOARCH and GOOS when building [kvrocks-controller]
Posted by "git-hulk (via GitHub)" <gi...@apache.org>.
git-hulk commented on code in PR #218:
URL: https://github.com/apache/kvrocks-controller/pull/218#discussion_r1844921818
##########
scripts/build.sh:
##########
@@ -86,17 +32,9 @@ for TARGET_NAME in "$SERVER_TARGET_NAME" "$CLIENT_TARGET_NAME"; do
CMD_PATH="${GO_PROJECT}/cmd/client"
fi
- if [[ "$BUILDER_IMAGE" == "none" ]]; then
- GOOS="$TARGET_OS" GOARCH="$TARGET_ARCH" CGO_ENABLED=0 go build -v -ldflags \
- "-X $GO_PROJECT/version.Version=$VERSION" \
- -o ${TARGET_NAME} ${CMD_PATH}
- else
- docker run --rm --privileged -it -v $(pwd):/${TARGET_NAME} -w /${TARGET_NAME} \
- -e GOOS="$TARGET_OS" -e GOARCH="$TARGET_ARCH" -e CGO_ENABLED=0 \
- $BUILDER_IMAGE go build -v -ldflags \
- "-X $GO_PROJECT/version.Version=$VERSION" \
- -o /${TARGET_NAME}/${TARGET_NAME} ${CMD_PATH}
- fi
+ GOOS="$TARGET_OS" GOARCH="$TARGET_ARCH" CGO_ENABLED=0 go build -v -ldflags \
Review Comment:
Yes, I forgot to remove then from the build command.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org