You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@druid.apache.org by GitBox <gi...@apache.org> on 2021/10/05 20:25:53 UTC
[GitHub] [druid] AlexanderSaydakov opened a new pull request #11773: latest datasketches-java and datasketches-memory
AlexanderSaydakov opened a new pull request #11773:
URL: https://github.com/apache/druid/pull/11773
This is a code maintenance change to update dependency on apache/datasketches-java and apache/datasketches-memory and adjust some API calls as necessary. datasketches-memory maintains existing support for Java 8 and adds support for Java 9 up to Java 13. In Java9+, the library can now be declared as a JPMS module dependency in user applications.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] clintropolis merged pull request #11773: latest datasketches-java and datasketches-memory
Posted by GitBox <gi...@apache.org>.
clintropolis merged pull request #11773:
URL: https://github.com/apache/druid/pull/11773
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] AlexanderSaydakov commented on pull request #11773: latest datasketches-java and datasketches-memory
Posted by GitBox <gi...@apache.org>.
AlexanderSaydakov commented on pull request #11773:
URL: https://github.com/apache/druid/pull/11773#issuecomment-934915544
I believe it should be fixed, but I did not verify this myself.
I think that the configurable parameter still can be useful in some circumstances.
Quantile sketches never stops growing, however they grow very slowly (logarithmically). We have to chose a particular slot size for BufferAggregator to preallocate. That parameter controls the tradeoff between overestimated preallocation and too many sketches growing beyond that and moving to additionally allocated slots on heap.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] jihoonson commented on pull request #11773: latest datasketches-java and datasketches-memory
Posted by GitBox <gi...@apache.org>.
jihoonson commented on pull request #11773:
URL: https://github.com/apache/druid/pull/11773#issuecomment-938352748
Hmm, it sounds reasonable. We should still update our doc in that case though since the doc says the parameter is a temporary workaround. I will look into it. BTW, the CI failure seems legit. Can you update the [versions of `datasketches-java` and `datasketches-memory` in the licenses.yaml file](https://github.com/apache/druid/blob/master/licenses.yaml#L3613-L3629)?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] AlexanderSaydakov edited a comment on pull request #11773: latest datasketches-java and datasketches-memory
Posted by GitBox <gi...@apache.org>.
AlexanderSaydakov edited a comment on pull request #11773:
URL: https://github.com/apache/druid/pull/11773#issuecomment-934915544
I believe it should be fixed, but I did not verify this myself.
I think that the configurable parameter still can be useful in some circumstances.
Quantile sketches never stop growing, however they grow very slowly (logarithmically). We have to chose a particular slot size for BufferAggregator to preallocate. That parameter controls the tradeoff between overestimated preallocation and too many sketches growing beyond that and moving to additionally allocated slots on heap.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org