You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@hbase.apache.org by GitBox <gi...@apache.org> on 2021/12/14 15:21:11 UTC

[GitHub] [hbase] Apache9 commented on a change in pull request #3938: HBASE-26564 Retire the method visitLogEntryBeforeWrite without RegionInfo in WALActionListner

Apache9 commented on a change in pull request #3938:
URL: https://github.com/apache/hbase/pull/3938#discussion_r768772752



##########
File path: hbase-server/src/test/java/org/apache/hadoop/hbase/wal/TestWALFactory.java
##########
@@ -676,12 +676,12 @@ public void visitLogEntryBeforeWrite(RegionInfo info, WALKey logKey, WALEdit log
       increments++;
     }
 
-    @Override
-    public void visitLogEntryBeforeWrite(WALKey logKey, WALEdit logEdit) {
-      // To change body of implemented methods use File | Settings | File
-      // Templates.
-      increments++;
-    }
+//    @Override

Review comment:
       Just remove this method?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org