You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Dmitry Zhuk <dz...@twopensource.com> on 2017/10/11 17:34:35 UTC
Review Request 62898: Used variadic templates for protobuf handlers.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62898/
-----------------------------------------------------------
Review request for mesos and Benjamin Mahler.
Bugs: MESOS-6971
https://issues.apache.org/jira/browse/MESOS-6971
Repository: mesos
Description
-------
This simplifies code of `ProtobufProcess` by replacing it with variadic
templates implementation.
Diffs
-----
3rdparty/libprocess/include/process/protobuf.hpp 2b6b623e04c6d629647287e4bdf617a6f9e8d813
Diff: https://reviews.apache.org/r/62898/diff/1/
Testing
-------
make check
Thanks,
Dmitry Zhuk
Re: Review Request 62898: Used variadic templates for protobuf
handlers.
Posted by Benjamin Mahler <bm...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62898/#review187724
-----------------------------------------------------------
Ship it!
Ship It!
- Benjamin Mahler
On Oct. 11, 2017, 5:34 p.m., Dmitry Zhuk wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62898/
> -----------------------------------------------------------
>
> (Updated Oct. 11, 2017, 5:34 p.m.)
>
>
> Review request for mesos and Benjamin Mahler.
>
>
> Bugs: MESOS-6971
> https://issues.apache.org/jira/browse/MESOS-6971
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This simplifies code of `ProtobufProcess` by replacing it with variadic
> templates implementation.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/include/process/protobuf.hpp 2b6b623e04c6d629647287e4bdf617a6f9e8d813
>
>
> Diff: https://reviews.apache.org/r/62898/diff/1/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Dmitry Zhuk
>
>