You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@iotdb.apache.org by GitBox <gi...@apache.org> on 2020/09/02 03:08:10 UTC

[GitHub] [incubator-iotdb] wshao08 opened a new pull request #1673: Fix Sonar checking bugs

wshao08 opened a new pull request #1673:
URL: https://github.com/apache/incubator-iotdb/pull/1673


   This PR fixed Sonar reported bugs, which mainly includes:
   
   - Unclosing resources
   - improperly handled InterrputedException
   - remove() of ThreadLocal variables not called
   - Bad type conversion or comparison.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-iotdb] jixuan1989 commented on pull request #1673: [Sonar] Fix Sonar checking bugs

Posted by GitBox <gi...@apache.org>.
jixuan1989 commented on pull request #1673:
URL: https://github.com/apache/incubator-iotdb/pull/1673#issuecomment-685756392


   6 additional code smells.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-iotdb] qiaojialin merged pull request #1673: [Sonar] Fix Sonar checking bugs

Posted by GitBox <gi...@apache.org>.
qiaojialin merged pull request #1673:
URL: https://github.com/apache/incubator-iotdb/pull/1673


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org