You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tomcat.apache.org by re...@apache.org on 2022/03/23 20:07:03 UTC

[tomcat] branch main updated: Remove check disabling logging

This is an automated email from the ASF dual-hosted git repository.

remm pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/tomcat.git


The following commit(s) were added to refs/heads/main by this push:
     new 3bcbd5a  Remove check disabling logging
3bcbd5a is described below

commit 3bcbd5a9b7b6d52e1d6f85f2f421bb5021c12d66
Author: remm <re...@apache.org>
AuthorDate: Wed Mar 23 21:03:44 2022 +0100

    Remove check disabling logging
---
 java/org/apache/coyote/http2/Http2Parser.java         | 2 +-
 java/org/apache/coyote/http2/Http2UpgradeHandler.java | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/java/org/apache/coyote/http2/Http2Parser.java b/java/org/apache/coyote/http2/Http2Parser.java
index 8c67d84..9a4bf0c 100644
--- a/java/org/apache/coyote/http2/Http2Parser.java
+++ b/java/org/apache/coyote/http2/Http2Parser.java
@@ -338,7 +338,7 @@ class Http2Parser {
                 int id = ByteUtil.getTwoBytes(setting, 0);
                 long value = ByteUtil.getFourBytes(setting, 2);
                 Setting key = Setting.valueOf(id);
-                if (log.isDebugEnabled() && key == Setting.UNKNOWN) {
+                if (key == Setting.UNKNOWN) {
                     log.warn(sm.getString("connectionSettings.unknown",
                         connectionId, Integer.toString(id), Long.toString(value)));
                 }
diff --git a/java/org/apache/coyote/http2/Http2UpgradeHandler.java b/java/org/apache/coyote/http2/Http2UpgradeHandler.java
index 49427f5..64ad129 100644
--- a/java/org/apache/coyote/http2/Http2UpgradeHandler.java
+++ b/java/org/apache/coyote/http2/Http2UpgradeHandler.java
@@ -234,7 +234,7 @@ class Http2UpgradeHandler extends AbstractStream implements InternalHttpUpgradeH
                     int id = ByteUtil.getTwoBytes(settings, i * 6);
                     long value = ByteUtil.getFourBytes(settings, (i * 6) + 2);
                     Setting key = Setting.valueOf(id);
-                    if (log.isDebugEnabled() && key == Setting.UNKNOWN) {
+                    if (key == Setting.UNKNOWN) {
                         log.warn(sm.getString("connectionSettings.unknown",
                             connectionId, Integer.toString(id), Long.toString(value)));
                     }

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org