You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@mynewt.apache.org by gi...@git.apache.org on 2017/07/10 17:31:41 UTC

[GitHub] mkiiskila commented on a change in pull request #396: Support for HiFive1 board

mkiiskila commented on a change in pull request #396: Support for HiFive1 board
URL: https://github.com/apache/mynewt-core/pull/396#discussion_r126482804
 
 

 ##########
 File path: hw/bsp/hifive1/riscv_openocd.cfg
 ##########
 @@ -0,0 +1,34 @@
+adapter_khz     10000
 
 Review comment:
   The same comment regarding license blurb.
   
   Thanks for doing this as ftdi openocd device. It's great to have this as an example in one of the BSPs.
   Do you mind including the wiring info in text form either in this file, or README.md within this directory?
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services