[jira] [Comment Edited] (JCR-3534) Add JackrabbitSession.getValueByContentId method

["angela (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/JCR-3534?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13634903#comment-13634903 ] 

angela edited comment on JCR-3534 at 4/18/13 6:42 AM:
------------------------------------------------------

in general it seems that we agree on creating some sort of signing mechanism for the content identifier, right?
if that was true, i would suggest that tommaso (or whoever is working on this at the end) comes up with a patch.

regarding injecting the value:
without having a closer look i would expect that ValueFactory#createValue(String, PropertyType.BINARY) should
be sufficient to create the value from the content id. but we can still decide on that once we have the basics working.

regarding oak:
that's the main reason for me being really picky about the security impact... hacking something into jackrabbit-core is
one thing but since we have to implement that in oak as well it should be well-thought-out. 
                
      was (Author: anchela):
    in general it seems that we agree on creating some sort of signing mechanism for the content identifier, right?
if that was true, i would suggest that tommaso (or whoever is work on this at the end) comes up with a patch.

regarding injecting the value:
without having a closer look i would expect that ValueFactory#createValue(String, PropertyType.BINARY) should
be sufficient to create the value from the content id. but we can still decide on that once we have the basics working.

regarding oak:
that's the main reason for me being really picky about the security impact... hacking something into jackrabbit-core is
one thing but since we have to implement that in oak as well it should be well-thought-out. 
                  
> Add JackrabbitSession.getValueByContentId method
> ------------------------------------------------
>
>                 Key: JCR-3534
>                 URL: https://issues.apache.org/jira/browse/JCR-3534
>             Project: Jackrabbit Content Repository
>          Issue Type: New Feature
>          Components: jackrabbit-api, jackrabbit-core
>    Affects Versions: 2.6
>            Reporter: Felix Meschberger
>         Attachments: JCR-3534.patch
>
>
> we have a couple of use cases, where we would like to leverage the global data store to prevent sending around and copying around large binary data unnecessarily: We have two separate Jackrabbit instances configured to use the same DataStore (for the sake of this discussion assume we have the problems of concurrent access and garbage collection under control). When sending content from one instance to the other instance we don't want to send potentially large binary data (e.g. video files) if not needed.
> The idea is for the sender to just send the content identity from JackrabbitValue.getContentIdentity(). The receiver would then check whether the such content already exists and would reuse if so:
> String ci = contentIdentity_from_sender;
> try {
>     Value v = session.getValueByContentIdentity(ci);
>     Property p = targetNode.setProperty(propName, v);
> } catch (ItemNotFoundException ie) {
>     // unknown or invalid content Identity
> } catch (RepositoryException re) {
>     // some other exception
> }
> Thus the proposed JackrabbitSession.getValueByContentIdentity(String) method would allow for round tripping the JackrabbitValue.getContentIdentity() preventing superfluous binary data copying and moving. 
> See also the dev@ thread http://jackrabbit.markmail.org/thread/gedk5jsrp6offkhi

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira