You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2018/04/18 23:00:52 UTC

[GitHub] eric-haibin-lin commented on a change in pull request #10585: [MXNET-329] support SparseEmbedding with dense weight

eric-haibin-lin commented on a change in pull request #10585: [MXNET-329] support SparseEmbedding with dense weight
URL: https://github.com/apache/incubator-mxnet/pull/10585#discussion_r182593627
 
 

 ##########
 File path: tests/python/unittest/test_sparse_operator.py
 ##########
 @@ -1638,10 +1638,10 @@ def check_sparse_elementwise_sum_with_shape(stype, shape, n):
 @with_seed()
 def test_sparse_embedding():
     ''' test sparse embedding operator '''
-    def check_sparse_embedding(in_dim, out_dim, batch, densities, deterministic):
+    def check_sparse_embedding(in_dim, out_dim, batch, densities, deterministic, weight_stype):
 
 Review comment:
   deterministic is the param passed to mx.sym.contrib.SparseEmbedding. See line 1645

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services