You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/02/24 23:37:51 UTC
[GitHub] [airflow] potiuk opened a new pull request #14437: Upgrade to newer dependencies only set when setup changed for PR
potiuk opened a new pull request #14437:
URL: https://github.com/apache/airflow/pull/14437
Upgrade to newer dependencies is only set to something else than
false in two cases now:
* when setup.py or setup.cfg change
* when we are running push build
Previously - mistakenly - it was also set when "full_tests_needed"
label was set on a PR.
This caused for example the #19610 build to fail before
moto was limited to <2 in #14433.
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #14437: Upgrade to newer dependencies only set when setup changed for PR
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #14437:
URL: https://github.com/apache/airflow/pull/14437#issuecomment-785466696
@kaxil @ashb This fixes the reason why #19628 failed. It should not upgrade moto. It only upgraded it because it had 'full_tests_needed" set as label and this (by mistake) also set "upgrade_to_newer_dependencies".
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] kaxil merged pull request #14437: Upgrade to newer dependencies only set when setup changed for PR
Posted by GitBox <gi...@apache.org>.
kaxil merged pull request #14437:
URL: https://github.com/apache/airflow/pull/14437
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #14437: Upgrade to newer dependencies only set when setup changed for PR
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #14437:
URL: https://github.com/apache/airflow/pull/14437#issuecomment-785471079
The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest master at your convenience, or amend the last commit of the PR, and push it with --force-with-lease.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org