You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@storm.apache.org by "Sachin Pasalkar (JIRA)" <ji...@apache.org> on 2017/02/15 03:33:41 UTC
[jira] [Assigned] (STORM-2358) Update storm hdfs spout to remove
specific implementation handlings
[ https://issues.apache.org/jira/browse/STORM-2358?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Sachin Pasalkar reassigned STORM-2358:
--------------------------------------
Assignee: (was: Sachin Pasalkar)
> Update storm hdfs spout to remove specific implementation handlings
> -------------------------------------------------------------------
>
> Key: STORM-2358
> URL: https://issues.apache.org/jira/browse/STORM-2358
> Project: Apache Storm
> Issue Type: Improvement
> Components: storm-hdfs
> Affects Versions: 1.x
> Reporter: Sachin Pasalkar
> Labels: newbie
> Attachments: AbstractFileReader.java, FileReader.java, HDFSSpout.java, SequenceFileReader.java, TextFileReader.java
>
>
> I was looking at storm hdfs spout code in 1.x branch, I found below
> improvements can be made in below code.
> 1. Make org.apache.storm.hdfs.spout.AbstractFileReader as public so
> that it can be used in generics.
> 2. org.apache.storm.hdfs.spout.HdfsSpout requires readerType as
> String. It will be great to have class<? extends AbstractFileReader>
> readerType; So we will not use Class.forName at multiple places also it
> will help in below point.
> 3. HdfsSpout also needs to provide outFields which are declared as
> constants in each reader(e.g.SequenceFileReader). We can have abstract
> API AbstractFileReader in which return them to user to make it generic.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)