You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Anand Mazumdar <ma...@gmail.com> on 2015/12/12 00:51:37 UTC
Review Request 41275: Introduced a field for specifying grace period
in Shutdown Event for Executor V1 API.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41275/
-----------------------------------------------------------
Review request for mesos, Ben Mahler and Vinod Kone.
Bugs: MESOS-3550
https://issues.apache.org/jira/browse/MESOS-3550
Repository: mesos
Description
-------
This change introduces a field `grace_period_seconds` that specifies the time an agent would wait for the executor to terminate before forcefully destroying the container.
Diffs
-----
include/mesos/executor/executor.proto 8f97ad8952b3156e9c299a5a297693c8d2ffccd4
include/mesos/v1/executor/executor.proto 7eaa40bf38845befeba477d074396e7660a7b231
Diff: https://reviews.apache.org/r/41275/diff/
Testing
-------
make check
Thanks,
Anand Mazumdar
Re: Review Request 41275: Introduced a field for specifying grace
period in Shutdown Event for Executor V1 API.
Posted by Joseph Wu <jo...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41275/#review110363
-----------------------------------------------------------
include/mesos/executor/executor.proto (line 89)
<https://reviews.apache.org/r/41275/#comment170174>
s/an executor/the executor/
Nit: Oxford comma?
Ditto below.
include/mesos/executor/executor.proto (line 93)
<https://reviews.apache.org/r/41275/#comment170175>
Do you want to use `TimeInfo` (integer) here instead of a `double`?
- Joseph Wu
On Dec. 11, 2015, 3:51 p.m., Anand Mazumdar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41275/
> -----------------------------------------------------------
>
> (Updated Dec. 11, 2015, 3:51 p.m.)
>
>
> Review request for mesos, Ben Mahler and Vinod Kone.
>
>
> Bugs: MESOS-3550
> https://issues.apache.org/jira/browse/MESOS-3550
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This change introduces a field `grace_period_seconds` that specifies the time an agent would wait for the executor to terminate before forcefully destroying the container.
>
>
> Diffs
> -----
>
> include/mesos/executor/executor.proto 8f97ad8952b3156e9c299a5a297693c8d2ffccd4
> include/mesos/v1/executor/executor.proto 7eaa40bf38845befeba477d074396e7660a7b231
>
> Diff: https://reviews.apache.org/r/41275/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Anand Mazumdar
>
>
Re: Review Request 41275: Introduced a field for specifying grace
period in Shutdown Event for Executor V1 API.
Posted by Qian Zhang <zh...@cn.ibm.com>.
> On Dec. 14, 2015, 7:47 a.m., Qian Zhang wrote:
> > include/mesos/executor/executor.proto, line 96
> > <https://reviews.apache.org/r/41275/diff/1/?file=1160521#file1160521line96>
> >
> > Just a quicky question, how will agent fill this field when it asks the executor to shutdown? Is this something that executor itself can decide/configure? Or it is a per-slave configuration via slave command line option?
>
> Anand Mazumdar wrote:
> The agent can fill this field when it asks the executor to shutdown i.e. ( via the `Event::Shutdown` message ). The value of this field can be set via a slave command line option.
>
> Currently, the existing executor library implementation just uses a hard-coded value https://github.com/apache/mesos/blob/master/src/exec/exec.cpp#L83
Thanks Anand. And will we consider to fill this field per-framework? E.g., let framework set it in its FrameworkInfo when it register master since different framework may want different shutdown grace period for its executor. And in master, we can set a max grace period which is used to ensure the value set by framework is not too large.
- Qian
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41275/#review110143
-----------------------------------------------------------
On Dec. 12, 2015, 7:51 a.m., Anand Mazumdar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41275/
> -----------------------------------------------------------
>
> (Updated Dec. 12, 2015, 7:51 a.m.)
>
>
> Review request for mesos, Ben Mahler and Vinod Kone.
>
>
> Bugs: MESOS-3550
> https://issues.apache.org/jira/browse/MESOS-3550
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This change introduces a field `grace_period_seconds` that specifies the time an agent would wait for the executor to terminate before forcefully destroying the container.
>
>
> Diffs
> -----
>
> include/mesos/executor/executor.proto 8f97ad8952b3156e9c299a5a297693c8d2ffccd4
> include/mesos/v1/executor/executor.proto 7eaa40bf38845befeba477d074396e7660a7b231
>
> Diff: https://reviews.apache.org/r/41275/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Anand Mazumdar
>
>
Re: Review Request 41275: Introduced a field for specifying grace
period in Shutdown Event for Executor V1 API.
Posted by Anand Mazumdar <ma...@gmail.com>.
> On Dec. 13, 2015, 11:47 p.m., Qian Zhang wrote:
> > include/mesos/executor/executor.proto, line 96
> > <https://reviews.apache.org/r/41275/diff/1/?file=1160521#file1160521line96>
> >
> > Just a quicky question, how will agent fill this field when it asks the executor to shutdown? Is this something that executor itself can decide/configure? Or it is a per-slave configuration via slave command line option?
The agent can fill this field when it asks the executor to shutdown i.e. ( via the `Event::Shutdown` message ). The value of this field can be set via a slave command line option.
Currently, the existing executor library implementation just uses a hard-coded value https://github.com/apache/mesos/blob/master/src/exec/exec.cpp#L83
- Anand
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41275/#review110143
-----------------------------------------------------------
On Dec. 11, 2015, 11:51 p.m., Anand Mazumdar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41275/
> -----------------------------------------------------------
>
> (Updated Dec. 11, 2015, 11:51 p.m.)
>
>
> Review request for mesos, Ben Mahler and Vinod Kone.
>
>
> Bugs: MESOS-3550
> https://issues.apache.org/jira/browse/MESOS-3550
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This change introduces a field `grace_period_seconds` that specifies the time an agent would wait for the executor to terminate before forcefully destroying the container.
>
>
> Diffs
> -----
>
> include/mesos/executor/executor.proto 8f97ad8952b3156e9c299a5a297693c8d2ffccd4
> include/mesos/v1/executor/executor.proto 7eaa40bf38845befeba477d074396e7660a7b231
>
> Diff: https://reviews.apache.org/r/41275/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Anand Mazumdar
>
>
Re: Review Request 41275: Introduced a field for specifying grace
period in Shutdown Event for Executor V1 API.
Posted by Qian Zhang <zh...@cn.ibm.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41275/#review110143
-----------------------------------------------------------
include/mesos/executor/executor.proto (line 93)
<https://reviews.apache.org/r/41275/#comment169914>
Just a quicky question, how will agent fill this field when it asks the executor to shutdown? Is this something that executor itself can decide/configure? Or it is a per-slave configuration via slave command line option?
- Qian Zhang
On Dec. 12, 2015, 7:51 a.m., Anand Mazumdar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41275/
> -----------------------------------------------------------
>
> (Updated Dec. 12, 2015, 7:51 a.m.)
>
>
> Review request for mesos, Ben Mahler and Vinod Kone.
>
>
> Bugs: MESOS-3550
> https://issues.apache.org/jira/browse/MESOS-3550
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This change introduces a field `grace_period_seconds` that specifies the time an agent would wait for the executor to terminate before forcefully destroying the container.
>
>
> Diffs
> -----
>
> include/mesos/executor/executor.proto 8f97ad8952b3156e9c299a5a297693c8d2ffccd4
> include/mesos/v1/executor/executor.proto 7eaa40bf38845befeba477d074396e7660a7b231
>
> Diff: https://reviews.apache.org/r/41275/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Anand Mazumdar
>
>
Re: Review Request 41275: Introduced a field for specifying grace
period in shutdown event.
Posted by Anand Mazumdar <ma...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41275/
-----------------------------------------------------------
(Updated Jan. 12, 2016, 5:33 p.m.)
Review request for mesos, Ben Mahler and Vinod Kone.
Changes
-------
Modified summary to be smaller then magical `72` characters.
Summary (updated)
-----------------
Introduced a field for specifying grace period in shutdown event.
Bugs: MESOS-3550
https://issues.apache.org/jira/browse/MESOS-3550
Repository: mesos
Description
-------
This change introduces a field `grace_period_seconds` that specifies the time an agent would wait for the executor to terminate before forcefully destroying the container.
Diffs
-----
include/mesos/executor/executor.proto cc6b4f67da62dacf2fc649f00ba15a3fba98910b
include/mesos/v1/executor/executor.proto 4ecdaa0a468da1b271aa382a945d7e2a59c32449
Diff: https://reviews.apache.org/r/41275/diff/
Testing
-------
make check
Thanks,
Anand Mazumdar
Re: Review Request 41275: Introduced a field for specifying grace
period in shutdown event protobuf.
Posted by Anand Mazumdar <ma...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41275/
-----------------------------------------------------------
(Updated Jan. 12, 2016, 5:28 p.m.)
Review request for mesos, Ben Mahler and Vinod Kone.
Changes
-------
Review comments.
Summary (updated)
-----------------
Introduced a field for specifying grace period in shutdown event protobuf.
Bugs: MESOS-3550
https://issues.apache.org/jira/browse/MESOS-3550
Repository: mesos
Description
-------
This change introduces a field `grace_period_seconds` that specifies the time an agent would wait for the executor to terminate before forcefully destroying the container.
Diffs (updated)
-----
include/mesos/executor/executor.proto cc6b4f67da62dacf2fc649f00ba15a3fba98910b
include/mesos/v1/executor/executor.proto 4ecdaa0a468da1b271aa382a945d7e2a59c32449
Diff: https://reviews.apache.org/r/41275/diff/
Testing
-------
make check
Thanks,
Anand Mazumdar
Re: Review Request 41275: Introduced a field for specifying grace
period in Shutdown Event for Executor V1 API.
Posted by Anand Mazumdar <ma...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41275/
-----------------------------------------------------------
(Updated Jan. 12, 2016, 9:20 a.m.)
Review request for mesos, Ben Mahler and Vinod Kone.
Changes
-------
Rebased without addressing comments.
Bugs: MESOS-3550
https://issues.apache.org/jira/browse/MESOS-3550
Repository: mesos
Description
-------
This change introduces a field `grace_period_seconds` that specifies the time an agent would wait for the executor to terminate before forcefully destroying the container.
Diffs (updated)
-----
include/mesos/executor/executor.proto cc6b4f67da62dacf2fc649f00ba15a3fba98910b
include/mesos/v1/executor/executor.proto 4ecdaa0a468da1b271aa382a945d7e2a59c32449
Diff: https://reviews.apache.org/r/41275/diff/
Testing
-------
make check
Thanks,
Anand Mazumdar
Re: Review Request 41275: Introduced a field for specifying grace
period in Shutdown Event for Executor V1 API.
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41275/#review112219
-----------------------------------------------------------
Ship it!
Ship It!
- Vinod Kone
On Dec. 11, 2015, 11:51 p.m., Anand Mazumdar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41275/
> -----------------------------------------------------------
>
> (Updated Dec. 11, 2015, 11:51 p.m.)
>
>
> Review request for mesos, Ben Mahler and Vinod Kone.
>
>
> Bugs: MESOS-3550
> https://issues.apache.org/jira/browse/MESOS-3550
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This change introduces a field `grace_period_seconds` that specifies the time an agent would wait for the executor to terminate before forcefully destroying the container.
>
>
> Diffs
> -----
>
> include/mesos/executor/executor.proto 8f97ad8952b3156e9c299a5a297693c8d2ffccd4
> include/mesos/v1/executor/executor.proto 7eaa40bf38845befeba477d074396e7660a7b231
>
> Diff: https://reviews.apache.org/r/41275/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Anand Mazumdar
>
>
Re: Review Request 41275: Introduced a field for specifying grace
period in Shutdown Event for Executor V1 API.
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41275/#review112635
-----------------------------------------------------------
include/mesos/executor/executor.proto (line 91)
<https://reviews.apache.org/r/41275/#comment173137>
Also mention that TASK_LOST updates will be sent for any active tasks of this executor?
- Vinod Kone
On Dec. 11, 2015, 11:51 p.m., Anand Mazumdar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41275/
> -----------------------------------------------------------
>
> (Updated Dec. 11, 2015, 11:51 p.m.)
>
>
> Review request for mesos, Ben Mahler and Vinod Kone.
>
>
> Bugs: MESOS-3550
> https://issues.apache.org/jira/browse/MESOS-3550
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This change introduces a field `grace_period_seconds` that specifies the time an agent would wait for the executor to terminate before forcefully destroying the container.
>
>
> Diffs
> -----
>
> include/mesos/executor/executor.proto 8f97ad8952b3156e9c299a5a297693c8d2ffccd4
> include/mesos/v1/executor/executor.proto 7eaa40bf38845befeba477d074396e7660a7b231
>
> Diff: https://reviews.apache.org/r/41275/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Anand Mazumdar
>
>