[GitHub] [incubator-doris] yangzhg commented on a change in pull request #7131: Refactor olap scannode

[GitBox <gi...@apache.org>]

yangzhg commented on a change in pull request #7131:
URL: https://github.com/apache/incubator-doris/pull/7131#discussion_r767383815



##########
File path: be/src/exec/scan_node.h
##########
@@ -69,16 +69,15 @@ class ScanNode : public ExecNode {
 public:
     ScanNode(ObjectPool* pool, const TPlanNode& tnode, const DescriptorTbl& descs)
             : ExecNode(pool, tnode, descs) {}
-    virtual ~ScanNode() {}
 
     // Set up counters
-    virtual Status prepare(RuntimeState* state);
+    Status prepare(RuntimeState* state) override;
 
     // Convert scan_ranges into node-specific scan restrictions.  This should be
     // called after prepare()
     virtual Status set_scan_ranges(const std::vector<TScanRangeParams>& scan_ranges) = 0;
-
-    virtual bool is_scan_node() const { return true; }
+    

Review comment:
       remove this




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org