You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@buildr.apache.org by "Ittay Dror (JIRA)" <ji...@apache.org> on 2009/05/10 13:33:46 UTC
[jira] Created: (BUILDR-277) using EarTask#add leads to corrupted
manifest files
using EarTask#add leads to corrupted manifest files
---------------------------------------------------
Key: BUILDR-277
URL: https://issues.apache.org/jira/browse/BUILDR-277
Project: Buildr
Issue Type: Bug
Components: Packaging
Affects Versions: 1.3.4
Reporter: Ittay Dror
EarTask#component_clone uses Manifest#update_manifest. It seems like it is doing it wrong. Manifest#update_manifest yields the current manifest to a block and uses the result as the new manifest. Since the result of the block in EarTask#component_clone is
manifest.main['Class-Path'] = class_path.join(' ')
it means the new manifest is just the class_path (which is the de-facto behavior we see)
EarTask#component_clone is called by EarTask#add
In our tests, adding 'manifest' as the last line of the block solves the problem
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (BUILDR-277) using EarTask#add leads to corrupted
manifest files
Posted by "Antoine Toulme (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/BUILDR-277?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Antoine Toulme resolved BUILDR-277.
-----------------------------------
Resolution: Cannot Reproduce
Marked as cannot reproduce.
> using EarTask#add leads to corrupted manifest files
> ---------------------------------------------------
>
> Key: BUILDR-277
> URL: https://issues.apache.org/jira/browse/BUILDR-277
> Project: Buildr
> Issue Type: Bug
> Components: Packaging
> Affects Versions: 1.3.4
> Reporter: Ittay Dror
>
> EarTask#component_clone uses Manifest#update_manifest. It seems like it is doing it wrong. Manifest#update_manifest yields the current manifest to a block and uses the result as the new manifest. Since the result of the block in EarTask#component_clone is
> manifest.main['Class-Path'] = class_path.join(' ')
> it means the new manifest is just the class_path (which is the de-facto behavior we see)
> EarTask#component_clone is called by EarTask#add
> In our tests, adding 'manifest' as the last line of the block solves the problem
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (BUILDR-277) using EarTask#add leads to corrupted
manifest files
Posted by "Alex Boisvert (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/BUILDR-277?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12709225#action_12709225 ]
Alex Boisvert commented on BUILDR-277:
--------------------------------------
I tried reproducing this but came out short. Do you have an example that would help me write a spec for this?
> using EarTask#add leads to corrupted manifest files
> ---------------------------------------------------
>
> Key: BUILDR-277
> URL: https://issues.apache.org/jira/browse/BUILDR-277
> Project: Buildr
> Issue Type: Bug
> Components: Packaging
> Affects Versions: 1.3.4
> Reporter: Ittay Dror
>
> EarTask#component_clone uses Manifest#update_manifest. It seems like it is doing it wrong. Manifest#update_manifest yields the current manifest to a block and uses the result as the new manifest. Since the result of the block in EarTask#component_clone is
> manifest.main['Class-Path'] = class_path.join(' ')
> it means the new manifest is just the class_path (which is the de-facto behavior we see)
> EarTask#component_clone is called by EarTask#add
> In our tests, adding 'manifest' as the last line of the block solves the problem
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.