[GitHub] [iceberg] aokolnychyi commented on a change in pull request #1379: Spark: Estimate statistics using snapshot summary only for data tables

[GitBox <gi...@apache.org>]

aokolnychyi commented on a change in pull request #1379:
URL: https://github.com/apache/iceberg/pull/1379#discussion_r476604000



##########
File path: spark2/src/main/java/org/apache/iceberg/spark/source/Reader.java
##########
@@ -283,7 +284,8 @@ public Statistics estimateStatistics() {
       return new Stats(0L, 0L);
     }
 
-    if (filterExpressions == null || filterExpressions == Expressions.alwaysTrue()) {

Review comment:
       We had a wrong predicate before: we compared a list to an expression.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org