You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Joseph Wu <jo...@mesosphere.io> on 2015/11/11 22:10:00 UTC
Review Request 40199: Fix CMake build.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40199/
-----------------------------------------------------------
Review request for mesos, Alex Clemmer, Jojy Varghese, and Timothy Chen.
Repository: mesos
Description
-------
Error introduced in https://reviews.apache.org/r/38580/diff/25#0.
Diffs
-----
src/CMakeLists.txt c235209743de6e84deb44df31c61948f4dc8b8eb
Diff: https://reviews.apache.org/r/40199/diff/
Testing
-------
```
cmake ..
make check
```
Thanks,
Joseph Wu
Re: Review Request 40199: Fix CMake build.
Posted by Gilbert Song <so...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40199/#review106152
-----------------------------------------------------------
Ship it!
Ship It!
- Gilbert Song
On Nov. 11, 2015, 1:09 p.m., Joseph Wu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40199/
> -----------------------------------------------------------
>
> (Updated Nov. 11, 2015, 1:09 p.m.)
>
>
> Review request for mesos, Alex Clemmer, Jojy Varghese, and Timothy Chen.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Error introduced in https://reviews.apache.org/r/38580/diff/25#0.
>
>
> Diffs
> -----
>
> src/CMakeLists.txt c235209743de6e84deb44df31c61948f4dc8b8eb
>
> Diff: https://reviews.apache.org/r/40199/diff/
>
>
> Testing
> -------
>
> ```
> cmake ..
> make check
> ```
>
>
> Thanks,
>
> Joseph Wu
>
>
Re: Review Request 40199: Fix CMake build.
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40199/#review106162
-----------------------------------------------------------
Patch looks great!
Reviews applied: [40199]
All tests passed.
- Mesos ReviewBot
On Nov. 11, 2015, 9:09 p.m., Joseph Wu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40199/
> -----------------------------------------------------------
>
> (Updated Nov. 11, 2015, 9:09 p.m.)
>
>
> Review request for mesos, Alex Clemmer, Jojy Varghese, and Timothy Chen.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Error introduced in https://reviews.apache.org/r/38580/diff/25#0.
>
>
> Diffs
> -----
>
> src/CMakeLists.txt c235209743de6e84deb44df31c61948f4dc8b8eb
>
> Diff: https://reviews.apache.org/r/40199/diff/
>
>
> Testing
> -------
>
> ```
> cmake ..
> make check
> ```
>
>
> Thanks,
>
> Joseph Wu
>
>
Re: Review Request 40199: Fix CMake build.
Posted by Timothy Chen <tn...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40199/#review106158
-----------------------------------------------------------
Ship it!
Ship It!
- Timothy Chen
On Nov. 11, 2015, 9:09 p.m., Joseph Wu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40199/
> -----------------------------------------------------------
>
> (Updated Nov. 11, 2015, 9:09 p.m.)
>
>
> Review request for mesos, Alex Clemmer, Jojy Varghese, and Timothy Chen.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Error introduced in https://reviews.apache.org/r/38580/diff/25#0.
>
>
> Diffs
> -----
>
> src/CMakeLists.txt c235209743de6e84deb44df31c61948f4dc8b8eb
>
> Diff: https://reviews.apache.org/r/40199/diff/
>
>
> Testing
> -------
>
> ```
> cmake ..
> make check
> ```
>
>
> Thanks,
>
> Joseph Wu
>
>
Re: Review Request 40199: Fix CMake build.
Posted by Jojy Varghese <jo...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40199/#review106151
-----------------------------------------------------------
Ship it!
Ship It!
- Jojy Varghese
On Nov. 11, 2015, 9:09 p.m., Joseph Wu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40199/
> -----------------------------------------------------------
>
> (Updated Nov. 11, 2015, 9:09 p.m.)
>
>
> Review request for mesos, Alex Clemmer, Jojy Varghese, and Timothy Chen.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Error introduced in https://reviews.apache.org/r/38580/diff/25#0.
>
>
> Diffs
> -----
>
> src/CMakeLists.txt c235209743de6e84deb44df31c61948f4dc8b8eb
>
> Diff: https://reviews.apache.org/r/40199/diff/
>
>
> Testing
> -------
>
> ```
> cmake ..
> make check
> ```
>
>
> Thanks,
>
> Joseph Wu
>
>
Re: Review Request 40199: Fix CMake build.
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40199/#review106157
-----------------------------------------------------------
Patch looks great!
Reviews applied: [40199]
All tests passed.
- Mesos ReviewBot
On Nov. 11, 2015, 9:09 p.m., Joseph Wu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40199/
> -----------------------------------------------------------
>
> (Updated Nov. 11, 2015, 9:09 p.m.)
>
>
> Review request for mesos, Alex Clemmer, Jojy Varghese, and Timothy Chen.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Error introduced in https://reviews.apache.org/r/38580/diff/25#0.
>
>
> Diffs
> -----
>
> src/CMakeLists.txt c235209743de6e84deb44df31c61948f4dc8b8eb
>
> Diff: https://reviews.apache.org/r/40199/diff/
>
>
> Testing
> -------
>
> ```
> cmake ..
> make check
> ```
>
>
> Thanks,
>
> Joseph Wu
>
>