You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by GitBox <gi...@apache.org> on 2022/02/23 21:19:39 UTC
[GitHub] [maven-surefire] slawekjaranowski opened a new pull request #474: [SUREFIRE-2000] Improve assertions in Surefire1787JUnit5IT
slawekjaranowski opened a new pull request #474:
URL: https://github.com/apache/maven-surefire/pull/474
Following this checklist to help us incorporate your
contribution quickly and easily:
- [x] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/SUREFIRE) filed
for the change (usually before you start working on it). Trivial changes like typos do not
require a JIRA issue. Your pull request should address just this issue, without
pulling in other changes.
- [x] Each commit in the pull request should have a meaningful subject line and body.
- [x] Format the pull request title like `[SUREFIRE-XXX] - Fixes bug in ApproximateQuantiles`,
where you replace `SUREFIRE-XXX` with the appropriate JIRA issue. Best practice
is to use the JIRA issue title in the pull request title and in the first line of the
commit message.
- [x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
- [x] Run `mvn clean install` to make sure basic checks pass. A more thorough check will
be performed on your pull request automatically.
- [x] You have run the integration tests successfully (`mvn -Prun-its clean install`).
If your pull request is about ~20 lines of code you don't need to sign an
[Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf) if you are unsure
please ask on the developers list.
To make clear that you license your contribution under
the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
you have to acknowledge this by using the following check-box.
- [x] I hereby declare this contribution to be licenced under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
- [x] In any other case, please file an [Apache Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-surefire] Tibor17 commented on a change in pull request #474: [SUREFIRE-2000] Improve assertions in Surefire1787JUnit5IT
Posted by GitBox <gi...@apache.org>.
Tibor17 commented on a change in pull request #474:
URL: https://github.com/apache/maven-surefire/pull/474#discussion_r813435614
##########
File path: surefire-its/src/test/java/org/apache/maven/surefire/its/jiras/Surefire1787JUnit5IT.java
##########
@@ -109,14 +115,18 @@ public void testNgWithJupiterEngine()
.executeTest()
.verifyErrorFree( 2 )
.verifyTextInLog( "Running pkg.JUnit5Test" )
- .verifyTextInLog( "Running pkg.TestNGTest" );
+ .verifyTextInLog( "Running pkg.TestNGTest" )
+ .verifyTextInLog(
+ "Using auto detected provider org.apache.maven.surefire.junitplatform.JUnitPlatformProvider" );
}
@Test
public void junit4Runner()
{
unpack( "junit5-runner" )
.executeTest()
- .verifyErrorFreeLog();
+ .verifyErrorFree( 1 )
+ .verifyTextInLog( "Running pkg.JUnit5Tests" )
+ .verifyTextInLog( "Using auto detected provider org.apache.maven.surefire.junit4.JUnit4Provider" );
Review comment:
`JUnit4Provider` is the actual status with the bug in ASM.
It should be `JUnitPlatformProvider` after the final fix. WDYT?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-surefire] slawekjaranowski commented on pull request #474: [SUREFIRE-2000] Improve assertions in Surefire1787JUnit5IT
Posted by GitBox <gi...@apache.org>.
slawekjaranowski commented on pull request #474:
URL: https://github.com/apache/maven-surefire/pull/474#issuecomment-1049567410
@Tibor17
I will create separate jira issue for it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-surefire] slawekjaranowski merged pull request #474: [SUREFIRE-2026] Improve assertions in Surefire1787JUnit5IT
Posted by GitBox <gi...@apache.org>.
slawekjaranowski merged pull request #474:
URL: https://github.com/apache/maven-surefire/pull/474
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-surefire] Tibor17 commented on pull request #474: [SUREFIRE-2000] Improve assertions in Surefire1787JUnit5IT
Posted by GitBox <gi...@apache.org>.
Tibor17 commented on pull request #474:
URL: https://github.com/apache/maven-surefire/pull/474#issuecomment-1049348799
@slawekjaranowski
If you want to use this Jira ticket, we should rename it in Jira.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-surefire] Tibor17 commented on pull request #474: [SUREFIRE-2026] Improve assertions in Surefire1787JUnit5IT
Posted by GitBox <gi...@apache.org>.
Tibor17 commented on pull request #474:
URL: https://github.com/apache/maven-surefire/pull/474#issuecomment-1050118230
@slawekjaranowski
Good job!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-surefire] slawekjaranowski commented on pull request #474: [SUREFIRE-2026] Improve assertions in Surefire1787JUnit5IT
Posted by GitBox <gi...@apache.org>.
slawekjaranowski commented on pull request #474:
URL: https://github.com/apache/maven-surefire/pull/474#issuecomment-1050103776
new issue was created, and PR updated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-surefire] slawekjaranowski commented on a change in pull request #474: [SUREFIRE-2000] Improve assertions in Surefire1787JUnit5IT
Posted by GitBox <gi...@apache.org>.
slawekjaranowski commented on a change in pull request #474:
URL: https://github.com/apache/maven-surefire/pull/474#discussion_r813607241
##########
File path: surefire-its/src/test/java/org/apache/maven/surefire/its/jiras/Surefire1787JUnit5IT.java
##########
@@ -109,14 +115,18 @@ public void testNgWithJupiterEngine()
.executeTest()
.verifyErrorFree( 2 )
.verifyTextInLog( "Running pkg.JUnit5Test" )
- .verifyTextInLog( "Running pkg.TestNGTest" );
+ .verifyTextInLog( "Running pkg.TestNGTest" )
+ .verifyTextInLog(
+ "Using auto detected provider org.apache.maven.surefire.junitplatform.JUnitPlatformProvider" );
}
@Test
public void junit4Runner()
{
unpack( "junit5-runner" )
.executeTest()
- .verifyErrorFreeLog();
+ .verifyErrorFree( 1 )
+ .verifyTextInLog( "Running pkg.JUnit5Tests" )
+ .verifyTextInLog( "Using auto detected provider org.apache.maven.surefire.junit4.JUnit4Provider" );
Review comment:
It is ok IMHO. When we want Junit5 test using Junit4 we add junit-platform-runner as a dependency.
https://junit.org/junit5/docs/current/user-guide/#running-tests-junit-platform-runner
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-surefire] Tibor17 commented on pull request #474: [SUREFIRE-2000] Improve assertions in Surefire1787JUnit5IT
Posted by GitBox <gi...@apache.org>.
Tibor17 commented on pull request #474:
URL: https://github.com/apache/maven-surefire/pull/474#issuecomment-1049354519
@slawekjaranowski
This patch of method `getJUnit5Artifact` in `AbstractSurefireMojo` should fix it and then the Line 130 should be fixed again in `Surefire1787JUnit5IT`.
```java
private Artifact getJUnit5Artifact()
{
Artifact artifact = getPluginArtifactMap().get( "org.junit.platform:junit-platform-engine" );
if ( artifact == null )
{
artifact = getProjectArtifactMap().get( "org.junit.platform:junit-platform-runner" );
}
if ( artifact == null )
{
return getProjectArtifactMap().get( "org.junit.platform:junit-platform-commons" );
}
return artifact;
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org