[jira] [Commented] (TS-1369) TS_SDK_VERSION the same across incompatible API's

["James Peach (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/TS-1369?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13418571#comment-13418571 ] 

James Peach commented on TS-1369:
---------------------------------

Since we make incompatible changes to some APIs, we should bump the version defines somehow for the 3.2.1 release.
                
> TS_SDK_VERSION the same across incompatible API's
> -------------------------------------------------
>
>                 Key: TS-1369
>                 URL: https://issues.apache.org/jira/browse/TS-1369
>             Project: Traffic Server
>          Issue Type: Bug
>          Components: TS API
>    Affects Versions: 3.2.1, 3.2.0, 3.1.3, 3.1.2
>            Reporter: Phil Sorber
>              Labels: api-change
>
> {noformat}
> 14:31 < PSUdaemon> what is the plan for TS_SDK_VERSION?
> 14:32 < PSUdaemon> i noticed the API changed from 3.0 to 3.2 but the TS_SDK_VERSION is the same
> 14:32 < PSUdaemon> at TS_SDK_VERSION_3_0
> 14:39 <@jpeach> I'm not sure when TS_SDK_VERSION is supposed to rev
> 14:39 <@jpeach> 3.2 removed some deprecated APIs and added a few new ones
> 14:39 < PSUdaemon> and altered some too
> 14:39 < PSUdaemon> like TSFetchUrl
> 14:39 <@jpeach> APIs that were retained are supposed to be binary and source compatible
> 14:40 <@jpeach> oh, it grew a sockaddr argument, right?
> 14:40 < PSUdaemon> and lost and ip/port argument
> 14:41 < PSUdaemon> i like the upgrade, just the compatibility changes too
> 14:41 <@jpeach> yeh sounds like we should have revved it
> 14:42 <@jpeach> can you file a jura ticket and we can discuss revving for 3.2.1
> 14:42 < PSUdaemon> sure
> {noformat}
> 3.0:
> {noformat}
> tsapi void TSFetchUrl(const char* headers, int request_len, unsigned int ip, int port , TSCont contp, TSFetchWakeUpOptions callback_options,TSFetchEvent events);
> {noformat}
> 3.2:
> {noformat}
> tsapi void TSFetchUrl(const char* request,int request_len, struct sockaddr const* addr, TSCont contp, TSFetchWakeUpOptions callback_options,TSFetchEvent event);
> {noformat}

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira