You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by "Chen-BUPT (via GitHub)" <gi...@apache.org> on 2025/12/08 13:58:30 UTC
[PR] feat:update dubbo-go to latest version #828 [dubbo-go-pixiu]
Chen-BUPT opened a new pull request, #833:
URL: https://github.com/apache/dubbo-go-pixiu/pull/833
1. 依赖升级：go.mod 升到 dubbo-go v3.3.0，配套 dubbo-getty v1.4.10、hessian2 v1.12.5、triple v1.2.2-rc4，并 tidy go.sum。
2. 配置调整：configs/conf.yaml 与 configs/conf_with_nacos.yaml 的 idle/read/write/shutdown 超时改为毫秒，匹配 3.3 的配置解析。
3. 注册中心：ZK 适配改用 metadata/info（3.3 中 metadata/definition 移除），保持服务元数据正常上报。
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
Re: [PR] feat:update dubbo-go to latest version #828 [dubbo-go-pixiu]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #833:
URL: https://github.com/apache/dubbo-go-pixiu/pull/833#issuecomment-3652905819
## [Codecov](https://app.codecov.io/gh/apache/dubbo-go-pixiu/pull/833?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `68.26923%` with `33 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 21.42%. Comparing base ([`26606a8`](https://app.codecov.io/gh/apache/dubbo-go-pixiu/commit/26606a8317ac79fb8ce826138a34908b62beae1c?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`1433833`](https://app.codecov.io/gh/apache/dubbo-go-pixiu/commit/14338335ff725143375357099ffcccc7a83ceeb7?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 97 commits behind head on develop.
| [Files with missing lines](https://app.codecov.io/gh/apache/dubbo-go-pixiu/pull/833?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [pkg/client/dubbo/dubbo.go](https://app.codecov.io/gh/apache/dubbo-go-pixiu/pull/833?src=pr&el=tree&filepath=pkg%2Fclient%2Fdubbo%2Fdubbo.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-cGtnL2NsaWVudC9kdWJiby9kdWJiby5nbw==) | 0.00% | [10 Missing :warning: ](https://app.codecov.io/gh/apache/dubbo-go-pixiu/pull/833?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...registry/zookeeper/application\_service\_listener.go](https://app.codecov.io/gh/apache/dubbo-go-pixiu/pull/833?src=pr&el=tree&filepath=pkg%2Fadapter%2Fdubboregistry%2Fregistry%2Fzookeeper%2Fapplication_service_listener.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-cGtnL2FkYXB0ZXIvZHViYm9yZWdpc3RyeS9yZWdpc3RyeS96b29rZWVwZXIvYXBwbGljYXRpb25fc2VydmljZV9saXN0ZW5lci5nbw==) | 0.00% | [5 Missing :warning: ](https://app.codecov.io/gh/apache/dubbo-go-pixiu/pull/833?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [pkg/config/xds/apiclient/grpc.go](https://app.codecov.io/gh/apache/dubbo-go-pixiu/pull/833?src=pr&el=tree&filepath=pkg%2Fconfig%2Fxds%2Fapiclient%2Fgrpc.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-cGtnL2NvbmZpZy94ZHMvYXBpY2xpZW50L2dycGMuZ28=) | 64.28% | [3 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/dubbo-go-pixiu/pull/833?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [pkg/filter/llm/tokenizer/tokenizer.go](https://app.codecov.io/gh/apache/dubbo-go-pixiu/pull/833?src=pr&el=tree&filepath=pkg%2Ffilter%2Fllm%2Ftokenizer%2Ftokenizer.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-cGtnL2ZpbHRlci9sbG0vdG9rZW5pemVyL3Rva2VuaXplci5nbw==) | 86.48% | [5 Missing :warning: ](https://app.codecov.io/gh/apache/dubbo-go-pixiu/pull/833?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [pkg/filter/metric/metric.go](https://app.codecov.io/gh/apache/dubbo-go-pixiu/pull/833?src=pr&el=tree&filepath=pkg%2Ffilter%2Fmetric%2Fmetric.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-cGtnL2ZpbHRlci9tZXRyaWMvbWV0cmljLmdv) | 86.66% | [4 Missing :warning: ](https://app.codecov.io/gh/apache/dubbo-go-pixiu/pull/833?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [pkg/server/otel.go](https://app.codecov.io/gh/apache/dubbo-go-pixiu/pull/833?src=pr&el=tree&filepath=pkg%2Fserver%2Fotel.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-cGtnL3NlcnZlci9vdGVsLmdv) | 0.00% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/dubbo-go-pixiu/pull/833?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [pkg/server/dynamic\_resource\_manager.go](https://app.codecov.io/gh/apache/dubbo-go-pixiu/pull/833?src=pr&el=tree&filepath=pkg%2Fserver%2Fdynamic_resource_manager.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-cGtnL3NlcnZlci9keW5hbWljX3Jlc291cmNlX21hbmFnZXIuZ28=) | 80.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/dubbo-go-pixiu/pull/833?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
> :exclamation: There is a different number of reports uploaded between BASE (26606a8) and HEAD (1433833). Click for more details.
>
> <details><summary>HEAD has 1 upload less than BASE</summary>
>
>| Flag | BASE (26606a8) | HEAD (1433833) |
>|------|------|------|
>||1|0|
></details>
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## develop #833 +/- ##
============================================
- Coverage 54.67% 21.42% -33.25%
============================================
Files 671 246 -425
Lines 78658 16162 -62496
============================================
- Hits 43006 3463 -39543
+ Misses 31981 12339 -19642
+ Partials 3671 360 -3311
```
| [Flag](https://app.codecov.io/gh/apache/dubbo-go-pixiu/pull/833/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [unittests](https://app.codecov.io/gh/apache/dubbo-go-pixiu/pull/833/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `21.42% <68.26%> (?)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
</details>
[:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/dubbo-go-pixiu/pull/833?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
- :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
Re: [PR] feat:update dubbo-go to latest version #828 [dubbo-go-pixiu]
Posted by "sonarqubecloud[bot] (via GitHub)" <gi...@apache.org>.
sonarqubecloud[bot] commented on PR #833:
URL: https://github.com/apache/dubbo-go-pixiu/pull/833#issuecomment-3640584552
## [](https://sonarcloud.io/dashboard?id=apache_dubbo-go-pixiu&pullRequest=833) **Quality Gate passed**
Issues
 [2 New issues](https://sonarcloud.io/project/issues?id=apache_dubbo-go-pixiu&pullRequest=833&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [0 Accepted issues](https://sonarcloud.io/project/issues?id=apache_dubbo-go-pixiu&pullRequest=833&issueStatuses=ACCEPTED)
Measures
 [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_dubbo-go-pixiu&pullRequest=833&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [0.0% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_dubbo-go-pixiu&pullRequest=833&metric=new_coverage&view=list)
 [14.1% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_dubbo-go-pixiu&pullRequest=833&metric=new_duplicated_lines_density&view=list)
[See analysis details on SonarQube Cloud](https://sonarcloud.io/dashboard?id=apache_dubbo-go-pixiu&pullRequest=833)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
Re: [PR] feat:update dubbo-go to latest version #828 [dubbo-go-pixiu]
Posted by "Chen-BUPT (via GitHub)" <gi...@apache.org>.
Chen-BUPT commented on code in PR #833:
URL: https://github.com/apache/dubbo-go-pixiu/pull/833#discussion_r2616927689
##########
pkg/filter/metric/metric_test.go:
##########
@@ -259,13 +276,29 @@ func TestFilterWithPullMode(t *testing.T) {
// TestFilterWithPushMode tests filter encode with push mode
func TestFilterWithPushMode(t *testing.T) {
+ restore := withTempPromRegistry(t)
+ defer restore()
+
+ pushCh := make(chan struct{}, 1)
+ var pushHits int32
+ server := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
+ io.Copy(io.Discard, r.Body)
+ atomic.AddInt32(&pushHits, 1)
+ select {
+ case pushCh <- struct{}{}:
+ default:
+ }
+ w.WriteHeader(http.StatusAccepted)
+ }))
+ defer server.Close()
+
factory := &FilterFactory{
cfg: &Config{
Mode: "push",
Push: PushConfig{
- GatewayURL: "http://localhost:9091",
+ GatewayURL: server.URL,
Review Comment:
这里之前因为重复在一个进程注册多个Prometheus Collector报错了 所以选择独立的Prometheus Registry每个测试方法都分配了个独立的端口 这样保证了不同测试是互相隔离的 生成mock服务的逻辑是随机的端口 所以用的server.url 在start的方法里获取到的url
##########
configs/conf.yaml:
##########
@@ -50,9 +50,9 @@ static_resources:
allow_credentials: false
config:
- idle_timeout: "5s"
- read_timeout: "5s"
- write_timeout: "5s"
+ idle_timeout: "5000ms"
+ read_timeout: "5000ms"
+ write_timeout: "5000ms"
Review Comment:
这个非必要
##########
pkg/filter/metric/metric_test.go:
##########
@@ -409,14 +449,30 @@ func TestMetricReporterPullMode(t *testing.T) {
// TestMetricReporterPushMode tests push mode with Prometheus Push Gateway.
func TestMetricReporterPushMode(t *testing.T) {
+ restore := withTempPromRegistry(t)
+ defer restore()
+
+ pushCh := make(chan struct{}, 1)
+ var pushHits int32
+ server := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
+ io.Copy(io.Discard, r.Body)
+ atomic.AddInt32(&pushHits, 1)
+ select {
+ case pushCh <- struct{}{}:
+ default:
+ }
+ w.WriteHeader(http.StatusAccepted)
+ }))
+ defer server.Close()
+
// Create factory with push mode
factory := &FilterFactory{
cfg: &Config{
Mode: "push",
Push: PushConfig{
- GatewayURL: "http://127.0.0.1:9091",
+ GatewayURL: server.URL,
Review Comment:
这里之前因为重复在一个进程注册多个Prometheus Collector报错了 所以选择独立的Prometheus Registry每个测试方法都分配了个独立的端口 这样保证了不同测试是互相隔离的 生成mock服务的逻辑是随机的端口 所以用的server.url 在start的方法里获取到的url
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
Re: [PR] feat:update dubbo-go to latest version #828 [dubbo-go-pixiu]
Posted by "Alanxtl (via GitHub)" <gi...@apache.org>.
Alanxtl commented on code in PR #833:
URL: https://github.com/apache/dubbo-go-pixiu/pull/833#discussion_r2600797075
##########
pkg/adapter/dubboregistry/registry/zookeeper/registry.go:
##########
@@ -53,9 +52,6 @@ const (
func init() {
registry.SetRegistry(constant.Zookeeper, newZKRegistry)
- hessian.RegisterPOJO(&dubboCommon.MetadataInfo{})
- hessian.RegisterPOJO(&dubboCommon.ServiceInfo{})
- hessian.RegisterPOJO(&dubboCommon.URL{})
Review Comment:
are u sure it is ok to delete these pojo registration?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
Re: [PR] feat:update dubbo-go to latest version #828 [dubbo-go-pixiu]
Posted by "sonarqubecloud[bot] (via GitHub)" <gi...@apache.org>.
sonarqubecloud[bot] commented on PR #833:
URL: https://github.com/apache/dubbo-go-pixiu/pull/833#issuecomment-3652433650
## [](https://sonarcloud.io/dashboard?id=apache_dubbo-go-pixiu&pullRequest=833) **Quality Gate passed**
Issues
 [2 New issues](https://sonarcloud.io/project/issues?id=apache_dubbo-go-pixiu&pullRequest=833&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [0 Accepted issues](https://sonarcloud.io/project/issues?id=apache_dubbo-go-pixiu&pullRequest=833&issueStatuses=ACCEPTED)
Measures
 [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_dubbo-go-pixiu&pullRequest=833&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [0.0% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_dubbo-go-pixiu&pullRequest=833&metric=new_coverage&view=list)
 [14.1% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_dubbo-go-pixiu&pullRequest=833&metric=new_duplicated_lines_density&view=list)
[See analysis details on SonarQube Cloud](https://sonarcloud.io/dashboard?id=apache_dubbo-go-pixiu&pullRequest=833)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
Re: [PR] feat:update dubbo-go to latest version #828 [dubbo-go-pixiu]
Posted by "sonarqubecloud[bot] (via GitHub)" <gi...@apache.org>.
sonarqubecloud[bot] commented on PR #833:
URL: https://github.com/apache/dubbo-go-pixiu/pull/833#issuecomment-3655297174
## [](https://sonarcloud.io/dashboard?id=apache_dubbo-go-pixiu&pullRequest=833) **Quality Gate passed**
Issues
 [4 New issues](https://sonarcloud.io/project/issues?id=apache_dubbo-go-pixiu&pullRequest=833&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [0 Accepted issues](https://sonarcloud.io/project/issues?id=apache_dubbo-go-pixiu&pullRequest=833&issueStatuses=ACCEPTED)
Measures
 [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_dubbo-go-pixiu&pullRequest=833&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [0.0% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_dubbo-go-pixiu&pullRequest=833&metric=new_coverage&view=list)
 [31.2% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_dubbo-go-pixiu&pullRequest=833&metric=new_duplicated_lines_density&view=list)
[See analysis details on SonarQube Cloud](https://sonarcloud.io/dashboard?id=apache_dubbo-go-pixiu&pullRequest=833)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
Re: [PR] feat:update dubbo-go to latest version #828 [dubbo-go-pixiu]
Posted by "Chen-BUPT (via GitHub)" <gi...@apache.org>.
Chen-BUPT commented on PR #833:
URL: https://github.com/apache/dubbo-go-pixiu/pull/833#issuecomment-3664178128
@Alanxtl All set
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
Re: [PR] feat:update dubbo-go to latest version #828 [dubbo-go-pixiu]
Posted by "sonarqubecloud[bot] (via GitHub)" <gi...@apache.org>.
sonarqubecloud[bot] commented on PR #833:
URL: https://github.com/apache/dubbo-go-pixiu/pull/833#issuecomment-3636003328
## [](https://sonarcloud.io/dashboard?id=apache_dubbo-go-pixiu&pullRequest=833) **Quality Gate passed**
Issues
 [2 New issues](https://sonarcloud.io/project/issues?id=apache_dubbo-go-pixiu&pullRequest=833&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [0 Accepted issues](https://sonarcloud.io/project/issues?id=apache_dubbo-go-pixiu&pullRequest=833&issueStatuses=ACCEPTED)
Measures
 [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_dubbo-go-pixiu&pullRequest=833&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [0.0% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_dubbo-go-pixiu&pullRequest=833&metric=new_coverage&view=list)
 [0.0% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_dubbo-go-pixiu&pullRequest=833&metric=new_duplicated_lines_density&view=list)
[See analysis details on SonarQube Cloud](https://sonarcloud.io/dashboard?id=apache_dubbo-go-pixiu&pullRequest=833)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
Re: [PR] feat:update dubbo-go to latest version #828 [dubbo-go-pixiu]
Posted by "Chen-BUPT (via GitHub)" <gi...@apache.org>.
Chen-BUPT commented on PR #833:
URL: https://github.com/apache/dubbo-go-pixiu/pull/833#issuecomment-3659005622
我现在有点怀疑集成测试里nacos注册不上是github action提供的虚拟机问题 我这次把等待时间加到了17s 再看看吧
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
Re: [PR] feat:update dubbo-go to latest version #828 [dubbo-go-pixiu]
Posted by "Chen-BUPT (via GitHub)" <gi...@apache.org>.
Chen-BUPT commented on PR #833:
URL: https://github.com/apache/dubbo-go-pixiu/pull/833#issuecomment-3659154391
<img width="753" height="130" alt="8f345246afdc8074303b99fe9d507d53" src="https://github.com/user-attachments/assets/ff68c725-ac85-4955-8908-33620b55dcf8" />
我自己手动测nacos sample是正常的
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
Re: [PR] feat:update dubbo-go to latest version #828 [dubbo-go-pixiu]
Posted by "sonarqubecloud[bot] (via GitHub)" <gi...@apache.org>.
sonarqubecloud[bot] commented on PR #833:
URL: https://github.com/apache/dubbo-go-pixiu/pull/833#issuecomment-3664178340
## [](https://sonarcloud.io/dashboard?id=apache_dubbo-go-pixiu&pullRequest=833) **Quality Gate passed**
Issues
 [2 New issues](https://sonarcloud.io/project/issues?id=apache_dubbo-go-pixiu&pullRequest=833&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [0 Accepted issues](https://sonarcloud.io/project/issues?id=apache_dubbo-go-pixiu&pullRequest=833&issueStatuses=ACCEPTED)
Measures
 [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_dubbo-go-pixiu&pullRequest=833&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [0.0% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_dubbo-go-pixiu&pullRequest=833&metric=new_coverage&view=list)
 [14.0% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_dubbo-go-pixiu&pullRequest=833&metric=new_duplicated_lines_density&view=list)
[See analysis details on SonarQube Cloud](https://sonarcloud.io/dashboard?id=apache_dubbo-go-pixiu&pullRequest=833)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
Re: [PR] feat:update dubbo-go to latest version #828 [dubbo-go-pixiu]
Posted by "Chen-BUPT (via GitHub)" <gi...@apache.org>.
Chen-BUPT commented on PR #833:
URL: https://github.com/apache/dubbo-go-pixiu/pull/833#issuecomment-3632610565
1. 把dubbo-go 3.3.0 升级到 v3.3.1-0.20251028122905-48c55c00b702
2. 解决了因dubbo-go升级连带OTel旧api失效导致的部分结构体报错问题, 也就是适配了OTel 1.21 (待讨论: metric_test里因新版otel不再支持重复注册指标而导致的CI爆红问题 目前是跳过了这个CI测试 因为其并不影响实际生产)
3. grpc.go和dynamic_resource_manager.go在本地CI测试时会爆空指针 于是加了一个判空的逻辑(只是增强代码健壮度 实际生产并不会遇到这些问题 如觉没必要可以删去)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
Re: [PR] feat:update dubbo-go to latest version #828 [dubbo-go-pixiu]
Posted by "Chen-BUPT (via GitHub)" <gi...@apache.org>.
Chen-BUPT commented on code in PR #833:
URL: https://github.com/apache/dubbo-go-pixiu/pull/833#discussion_r2602925908
##########
pkg/adapter/dubboregistry/registry/zookeeper/registry.go:
##########
@@ -53,9 +52,6 @@ const (
func init() {
registry.SetRegistry(constant.Zookeeper, newZKRegistry)
- hessian.RegisterPOJO(&dubboCommon.MetadataInfo{})
- hessian.RegisterPOJO(&dubboCommon.ServiceInfo{})
- hessian.RegisterPOJO(&dubboCommon.URL{})
Review Comment:
yeah ,those POJOs are auto‑registered by dubbo.apache.org/dubbo-go/v3/metadata/info via its init(). We keep the _ import so Hessian registration still happens; explicit hessian.RegisterPOJO calls are no longer needed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
Re: [PR] feat:update dubbo-go to latest version #828 [dubbo-go-pixiu]
Posted by "Alanxtl (via GitHub)" <gi...@apache.org>.
Alanxtl commented on code in PR #833:
URL: https://github.com/apache/dubbo-go-pixiu/pull/833#discussion_r2609362331
##########
pkg/filter/metric/config.go:
##########
@@ -19,13 +19,9 @@ package metric
import (
"fmt"
-)
-import (
- "go.opentelemetry.io/otel/metric/instrument/syncint64"
-)
+ "go.opentelemetry.io/otel/metric"
-import (
"github.com/apache/dubbo-go-pixiu/pkg/common/constant"
)
Review Comment:
import format here
why ci didn't fail here??
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
Re: [PR] feat:update dubbo-go to latest version #828 [dubbo-go-pixiu]
Posted by "sonarqubecloud[bot] (via GitHub)" <gi...@apache.org>.
sonarqubecloud[bot] commented on PR #833:
URL: https://github.com/apache/dubbo-go-pixiu/pull/833#issuecomment-3627075778
## [](https://sonarcloud.io/dashboard?id=apache_dubbo-go-pixiu&pullRequest=833) **Quality Gate passed**
Issues
 [0 New issues](https://sonarcloud.io/project/issues?id=apache_dubbo-go-pixiu&pullRequest=833&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [0 Accepted issues](https://sonarcloud.io/project/issues?id=apache_dubbo-go-pixiu&pullRequest=833&issueStatuses=ACCEPTED)
Measures
 [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_dubbo-go-pixiu&pullRequest=833&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [0.0% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_dubbo-go-pixiu&pullRequest=833&metric=new_coverage&view=list)
 [0.0% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_dubbo-go-pixiu&pullRequest=833&metric=new_duplicated_lines_density&view=list)
[See analysis details on SonarQube Cloud](https://sonarcloud.io/dashboard?id=apache_dubbo-go-pixiu&pullRequest=833)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
Re: [PR] feat:update dubbo-go to latest version #828 [dubbo-go-pixiu]
Posted by "sonarqubecloud[bot] (via GitHub)" <gi...@apache.org>.
sonarqubecloud[bot] commented on PR #833:
URL: https://github.com/apache/dubbo-go-pixiu/pull/833#issuecomment-3659005067
## [](https://sonarcloud.io/dashboard?id=apache_dubbo-go-pixiu&pullRequest=833) **Quality Gate passed**
Issues
 [4 New issues](https://sonarcloud.io/project/issues?id=apache_dubbo-go-pixiu&pullRequest=833&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [0 Accepted issues](https://sonarcloud.io/project/issues?id=apache_dubbo-go-pixiu&pullRequest=833&issueStatuses=ACCEPTED)
Measures
 [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_dubbo-go-pixiu&pullRequest=833&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [0.0% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_dubbo-go-pixiu&pullRequest=833&metric=new_coverage&view=list)
 [33.8% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_dubbo-go-pixiu&pullRequest=833&metric=new_duplicated_lines_density&view=list)
[See analysis details on SonarQube Cloud](https://sonarcloud.io/dashboard?id=apache_dubbo-go-pixiu&pullRequest=833)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
Re: [PR] feat:update dubbo-go to latest version #828 [dubbo-go-pixiu]
Posted by "sonarqubecloud[bot] (via GitHub)" <gi...@apache.org>.
sonarqubecloud[bot] commented on PR #833:
URL: https://github.com/apache/dubbo-go-pixiu/pull/833#issuecomment-3640607600
## [](https://sonarcloud.io/dashboard?id=apache_dubbo-go-pixiu&pullRequest=833) **Quality Gate passed**
Issues
 [2 New issues](https://sonarcloud.io/project/issues?id=apache_dubbo-go-pixiu&pullRequest=833&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [0 Accepted issues](https://sonarcloud.io/project/issues?id=apache_dubbo-go-pixiu&pullRequest=833&issueStatuses=ACCEPTED)
Measures
 [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_dubbo-go-pixiu&pullRequest=833&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [0.0% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_dubbo-go-pixiu&pullRequest=833&metric=new_coverage&view=list)
 [14.1% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_dubbo-go-pixiu&pullRequest=833&metric=new_duplicated_lines_density&view=list)
[See analysis details on SonarQube Cloud](https://sonarcloud.io/dashboard?id=apache_dubbo-go-pixiu&pullRequest=833)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
Re: [PR] feat:update dubbo-go to latest version #828 [dubbo-go-pixiu]
Posted by "sonarqubecloud[bot] (via GitHub)" <gi...@apache.org>.
sonarqubecloud[bot] commented on PR #833:
URL: https://github.com/apache/dubbo-go-pixiu/pull/833#issuecomment-3655161898
## [](https://sonarcloud.io/dashboard?id=apache_dubbo-go-pixiu&pullRequest=833) **Quality Gate passed**
Issues
 [4 New issues](https://sonarcloud.io/project/issues?id=apache_dubbo-go-pixiu&pullRequest=833&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [0 Accepted issues](https://sonarcloud.io/project/issues?id=apache_dubbo-go-pixiu&pullRequest=833&issueStatuses=ACCEPTED)
Measures
 [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_dubbo-go-pixiu&pullRequest=833&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [0.0% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_dubbo-go-pixiu&pullRequest=833&metric=new_coverage&view=list)
 [31.2% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_dubbo-go-pixiu&pullRequest=833&metric=new_duplicated_lines_density&view=list)
[See analysis details on SonarQube Cloud](https://sonarcloud.io/dashboard?id=apache_dubbo-go-pixiu&pullRequest=833)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
Re: [PR] feat:update dubbo-go to latest version #828 [dubbo-go-pixiu]
Posted by "Similarityoung (via GitHub)" <gi...@apache.org>.
Similarityoung commented on code in PR #833:
URL: https://github.com/apache/dubbo-go-pixiu/pull/833#discussion_r2616871283
##########
pkg/filter/metric/metric_test.go:
##########
@@ -259,13 +276,29 @@ func TestFilterWithPullMode(t *testing.T) {
// TestFilterWithPushMode tests filter encode with push mode
func TestFilterWithPushMode(t *testing.T) {
+ restore := withTempPromRegistry(t)
+ defer restore()
+
+ pushCh := make(chan struct{}, 1)
+ var pushHits int32
+ server := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
+ io.Copy(io.Discard, r.Body)
+ atomic.AddInt32(&pushHits, 1)
+ select {
+ case pushCh <- struct{}{}:
+ default:
+ }
+ w.WriteHeader(http.StatusAccepted)
+ }))
+ defer server.Close()
+
factory := &FilterFactory{
cfg: &Config{
Mode: "push",
Push: PushConfig{
- GatewayURL: "http://localhost:9091",
+ GatewayURL: server.URL,
Review Comment:
这里修改的意义是什么
##########
pkg/filter/metric/metric_test.go:
##########
@@ -409,14 +449,30 @@ func TestMetricReporterPullMode(t *testing.T) {
// TestMetricReporterPushMode tests push mode with Prometheus Push Gateway.
func TestMetricReporterPushMode(t *testing.T) {
+ restore := withTempPromRegistry(t)
+ defer restore()
+
+ pushCh := make(chan struct{}, 1)
+ var pushHits int32
+ server := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
+ io.Copy(io.Discard, r.Body)
+ atomic.AddInt32(&pushHits, 1)
+ select {
+ case pushCh <- struct{}{}:
+ default:
+ }
+ w.WriteHeader(http.StatusAccepted)
+ }))
+ defer server.Close()
+
// Create factory with push mode
factory := &FilterFactory{
cfg: &Config{
Mode: "push",
Push: PushConfig{
- GatewayURL: "http://127.0.0.1:9091",
+ GatewayURL: server.URL,
Review Comment:
同上
##########
configs/conf.yaml:
##########
@@ -50,9 +50,9 @@ static_resources:
allow_credentials: false
config:
- idle_timeout: "5s"
- read_timeout: "5s"
- write_timeout: "5s"
+ idle_timeout: "5000ms"
+ read_timeout: "5000ms"
+ write_timeout: "5000ms"
Review Comment:
这里需要修改成毫秒吗，这是配置 pixiu 本身的配置，需要跟 dubbo-go 配置同步吗
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
Re: [PR] feat:update dubbo-go to latest version #828 [dubbo-go-pixiu]
Posted by "sonarqubecloud[bot] (via GitHub)" <gi...@apache.org>.
sonarqubecloud[bot] commented on PR #833:
URL: https://github.com/apache/dubbo-go-pixiu/pull/833#issuecomment-3655001064
## [](https://sonarcloud.io/dashboard?id=apache_dubbo-go-pixiu&pullRequest=833) **Quality Gate passed**
Issues
 [4 New issues](https://sonarcloud.io/project/issues?id=apache_dubbo-go-pixiu&pullRequest=833&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [0 Accepted issues](https://sonarcloud.io/project/issues?id=apache_dubbo-go-pixiu&pullRequest=833&issueStatuses=ACCEPTED)
Measures
 [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_dubbo-go-pixiu&pullRequest=833&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [0.0% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_dubbo-go-pixiu&pullRequest=833&metric=new_coverage&view=list)
 [31.2% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_dubbo-go-pixiu&pullRequest=833&metric=new_duplicated_lines_density&view=list)
[See analysis details on SonarQube Cloud](https://sonarcloud.io/dashboard?id=apache_dubbo-go-pixiu&pullRequest=833)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
Re: [PR] feat:update dubbo-go to latest version #828 [dubbo-go-pixiu]
Posted by "Chen-BUPT (via GitHub)" <gi...@apache.org>.
Chen-BUPT commented on code in PR #833:
URL: https://github.com/apache/dubbo-go-pixiu/pull/833#discussion_r2609429660
##########
pkg/filter/metric/config.go:
##########
@@ -19,13 +19,9 @@ package metric
import (
"fmt"
-)
-import (
- "go.opentelemetry.io/otel/metric/instrument/syncint64"
-)
+ "go.opentelemetry.io/otel/metric"
-import (
"github.com/apache/dubbo-go-pixiu/pkg/common/constant"
)
Review Comment:
fixed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
Re: [PR] feat:update dubbo-go to latest version #828 [dubbo-go-pixiu]
Posted by "sonarqubecloud[bot] (via GitHub)" <gi...@apache.org>.
sonarqubecloud[bot] commented on PR #833:
URL: https://github.com/apache/dubbo-go-pixiu/pull/833#issuecomment-3632608301
## [](https://sonarcloud.io/dashboard?id=apache_dubbo-go-pixiu&pullRequest=833) **Quality Gate passed**
Issues
 [2 New issues](https://sonarcloud.io/project/issues?id=apache_dubbo-go-pixiu&pullRequest=833&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [0 Accepted issues](https://sonarcloud.io/project/issues?id=apache_dubbo-go-pixiu&pullRequest=833&issueStatuses=ACCEPTED)
Measures
 [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_dubbo-go-pixiu&pullRequest=833&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [0.0% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_dubbo-go-pixiu&pullRequest=833&metric=new_coverage&view=list)
 [0.0% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_dubbo-go-pixiu&pullRequest=833&metric=new_duplicated_lines_density&view=list)
[See analysis details on SonarQube Cloud](https://sonarcloud.io/dashboard?id=apache_dubbo-go-pixiu&pullRequest=833)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
Re: [PR] feat:update dubbo-go to latest version #828 [dubbo-go-pixiu]
Posted by "sonarqubecloud[bot] (via GitHub)" <gi...@apache.org>.
sonarqubecloud[bot] commented on PR #833:
URL: https://github.com/apache/dubbo-go-pixiu/pull/833#issuecomment-3640545641
## [](https://sonarcloud.io/dashboard?id=apache_dubbo-go-pixiu&pullRequest=833) **Quality Gate passed**
Issues
 [2 New issues](https://sonarcloud.io/project/issues?id=apache_dubbo-go-pixiu&pullRequest=833&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [0 Accepted issues](https://sonarcloud.io/project/issues?id=apache_dubbo-go-pixiu&pullRequest=833&issueStatuses=ACCEPTED)
Measures
 [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_dubbo-go-pixiu&pullRequest=833&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [0.0% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_dubbo-go-pixiu&pullRequest=833&metric=new_coverage&view=list)
 [14.1% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_dubbo-go-pixiu&pullRequest=833&metric=new_duplicated_lines_density&view=list)
[See analysis details on SonarQube Cloud](https://sonarcloud.io/dashboard?id=apache_dubbo-go-pixiu&pullRequest=833)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
Re: [PR] feat:update dubbo-go to latest version #828 [dubbo-go-pixiu]
Posted by "sonarqubecloud[bot] (via GitHub)" <gi...@apache.org>.
sonarqubecloud[bot] commented on PR #833:
URL: https://github.com/apache/dubbo-go-pixiu/pull/833#issuecomment-3640491463
## [](https://sonarcloud.io/dashboard?id=apache_dubbo-go-pixiu&pullRequest=833) **Quality Gate passed**
Issues
 [2 New issues](https://sonarcloud.io/project/issues?id=apache_dubbo-go-pixiu&pullRequest=833&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [0 Accepted issues](https://sonarcloud.io/project/issues?id=apache_dubbo-go-pixiu&pullRequest=833&issueStatuses=ACCEPTED)
Measures
 [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_dubbo-go-pixiu&pullRequest=833&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [0.0% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_dubbo-go-pixiu&pullRequest=833&metric=new_coverage&view=list)
 [14.1% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_dubbo-go-pixiu&pullRequest=833&metric=new_duplicated_lines_density&view=list)
[See analysis details on SonarQube Cloud](https://sonarcloud.io/dashboard?id=apache_dubbo-go-pixiu&pullRequest=833)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
Re: [PR] feat:update dubbo-go to latest version #828 [dubbo-go-pixiu]
Posted by "Alanxtl (via GitHub)" <gi...@apache.org>.
Alanxtl merged PR #833:
URL: https://github.com/apache/dubbo-go-pixiu/pull/833
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
Re: [PR] feat:update dubbo-go to latest version #828 [dubbo-go-pixiu]
Posted by "Chen-BUPT (via GitHub)" <gi...@apache.org>.
Chen-BUPT commented on PR #833:
URL: https://github.com/apache/dubbo-go-pixiu/pull/833#issuecomment-3654101838
CI测试中报错nacos测试中心没有发现实例 推测是时序问题 新增了重试机制
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
Re: [PR] feat:update dubbo-go to latest version #828 [dubbo-go-pixiu]
Posted by "sonarqubecloud[bot] (via GitHub)" <gi...@apache.org>.
sonarqubecloud[bot] commented on PR #833:
URL: https://github.com/apache/dubbo-go-pixiu/pull/833#issuecomment-3652515806
## [](https://sonarcloud.io/dashboard?id=apache_dubbo-go-pixiu&pullRequest=833) **Quality Gate passed**
Issues
 [2 New issues](https://sonarcloud.io/project/issues?id=apache_dubbo-go-pixiu&pullRequest=833&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [0 Accepted issues](https://sonarcloud.io/project/issues?id=apache_dubbo-go-pixiu&pullRequest=833&issueStatuses=ACCEPTED)
Measures
 [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_dubbo-go-pixiu&pullRequest=833&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [0.0% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_dubbo-go-pixiu&pullRequest=833&metric=new_coverage&view=list)
 [14.1% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_dubbo-go-pixiu&pullRequest=833&metric=new_duplicated_lines_density&view=list)
[See analysis details on SonarQube Cloud](https://sonarcloud.io/dashboard?id=apache_dubbo-go-pixiu&pullRequest=833)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org