[jira] [Commented] (WW-4145) file.ftl in xhtml theme directly references xhtml controlfooter.ftl

["Lukasz Lenart (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/WW-4145?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13726157#comment-13726157 ] 

Lukasz Lenart commented on WW-4145:
-----------------------------------

WoW! Great work!

One thing is wondering me, why not to move the code below to {{FreemarkerManager#init()}} ?

{code:java}
        synchronized (config) {
            TemplateLoader templateLoader = config.getTemplateLoader();
            if (!(templateLoader instanceof FreemarkerThemeTemplateLoader)) {
                config.setTemplateLoader(
                    new FreemarkerThemeTemplateLoader(uiThemeExpansionToken, templateLoader, this));
            }
        }
{code}
                
> file.ftl in xhtml theme directly references xhtml controlfooter.ftl
> -------------------------------------------------------------------
>
>                 Key: WW-4145
>                 URL: https://issues.apache.org/jira/browse/WW-4145
>             Project: Struts 2
>          Issue Type: Bug
>          Components: Other
>    Affects Versions: 2.3.15.1
>            Reporter: Jasper Rosenberg
>            Assignee: Lukasz Lenart
>              Labels: freemarker, tags, xhtml
>             Fix For: 2.3.16
>
>         Attachments: ThemeExpansion.patch
>
>
> Should use $\{parameters.theme} instead so can be used in theme extension.
> {code}
> <#include "/${parameters.templateDir}/${parameters.theme}/controlheader.ftl" />
> <#include "/${parameters.templateDir}/simple/file.ftl" />
> <#include "/${parameters.templateDir}/${parameters.theme}/controlfooter.ftl" />
> {code}

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira