You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@commons.apache.org by GitBox <gi...@apache.org> on 2020/11/09 12:04:09 UTC
[GitHub] [commons-lang] arturobernalg opened a new pull request #643: LANG-1420 - TypeUtils.isAssignable returns wrong result for GenericAr…
arturobernalg opened a new pull request #643:
URL: https://github.com/apache/commons-lang/pull/643
…rayType and ParameterizedType comparison
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-lang] garydgregory commented on a change in pull request #643: [LANG-1420] - TypeUtils.isAssignable returns wrong result for GenericAr…
Posted by GitBox <gi...@apache.org>.
garydgregory commented on a change in pull request #643:
URL: https://github.com/apache/commons-lang/pull/643#discussion_r523783371
##########
File path: src/main/java/org/apache/commons/lang3/reflect/TypeUtils.java
##########
@@ -424,6 +424,11 @@ private static boolean isAssignable(final Type type, final ParameterizedType toP
return true;
}
+ //the component type should not be assignable to the array type
Review comment:
This comment is backward.
I've committed a variation of the PR to git master with more tests.
I am wondering about other Type extensions. What do you think about `ypeUtilsTest.testIsAssignableGenericArrayTypeToWildercardType()`? See `isAssignable(Type, Type, Map<TypeVariable<?>, Type>)`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-lang] garydgregory closed pull request #643: [LANG-1420] - TypeUtils.isAssignable returns wrong result for GenericAr…
Posted by GitBox <gi...@apache.org>.
garydgregory closed pull request #643:
URL: https://github.com/apache/commons-lang/pull/643
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-lang] coveralls commented on pull request #643: [LANG-1420] - TypeUtils.isAssignable returns wrong result for GenericAr…
Posted by GitBox <gi...@apache.org>.
coveralls commented on pull request #643:
URL: https://github.com/apache/commons-lang/pull/643#issuecomment-723976153
[](https://coveralls.io/builds/34820560)
Coverage increased (+0.0006%) to 94.947% when pulling **11323655896d264b0f6582beb878baa595db46ad on arturobernalg:feature/LANG-1420** into **6b3f258ed7f8737740a22599458c0c468864b837 on apache:master**.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-lang] garydgregory commented on pull request #643: [LANG-1420] - TypeUtils.isAssignable returns wrong result for GenericAr…
Posted by GitBox <gi...@apache.org>.
garydgregory commented on pull request #643:
URL: https://github.com/apache/commons-lang/pull/643#issuecomment-727600269
Closing, see https://github.com/apache/commons-lang/pull/643#discussion_r523783371
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org