You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@openwhisk.apache.org by GitBox <gi...@apache.org> on 2020/10/06 06:00:32 UTC
[GitHub] [openwhisk] shazron opened a new pull request #4991: fix: add new Windows docker.exe location
shazron opened a new pull request #4991:
URL: https://github.com/apache/openwhisk/pull/4991
See https://github.com/docker/for-win/issues/7898
See https://github.com/adobe/aio-cli-plugin-app/issues/304
<!--- Provide a concise summary of your changes in the Title -->
## Description
The Windows docker.exe location has been changed, so the openwhisk.jar will fail to run since the search locations are hard-coded. This PR adds the new path to the search paths.
## My changes affect the following components
<!--- Select below all system components are affected by your change. -->
<!--- Enter an `x` in all applicable boxes. -->
- [ ] API
- [ ] Controller
- [ ] Message Bus (e.g., Kafka)
- [ ] Loadbalancer
- [ ] Invoker
- [ ] Intrinsic actions (e.g., sequences, conductors)
- [ ] Data stores (e.g., CouchDB)
- [ ] Tests
- [ ] Deployment
- [ ] CLI
- [X] General tooling
- [ ] Documentation
## Types of changes
<!--- What types of changes does your code introduce? Use `x` in all the boxes that apply: -->
- [X] Bug fix (generally a non-breaking change which closes an issue).
- [ ] Enhancement or new feature (adds new functionality).
- [ ] Breaking change (a bug fix or enhancement which changes existing behavior).
## Checklist:
<!--- Please review the points below which help you make sure you've covered all aspects of the change you're making. -->
- [X] I signed an [Apache CLA](https://github.com/apache/openwhisk/blob/master/CONTRIBUTING.md).
- [ ] I reviewed the [style guides](https://github.com/apache/openwhisk/wiki/Contributing:-Git-guidelines#code-readiness) and followed the recommendations (Travis CI will check :).
- [ ] I added tests to cover my changes.
- [ ] My changes require further changes to the documentation.
- [ ] I updated the documentation where necessary.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [openwhisk] shazron commented on pull request #4991: fix: add new Windows docker.exe location
Posted by GitBox <gi...@apache.org>.
shazron commented on pull request #4991:
URL: https://github.com/apache/openwhisk/pull/4991#issuecomment-704675573
The tests pass now (I fixed the Scala formatting).
For reference for others, to fix Scala formatting issues:
```
./gradlew checkScalaFmt
./gradelw scalaFmt
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [openwhisk] codecov-io commented on pull request #4991: fix: add new Windows docker.exe location
Posted by GitBox <gi...@apache.org>.
codecov-io commented on pull request #4991:
URL: https://github.com/apache/openwhisk/pull/4991#issuecomment-704670957
# [Codecov](https://codecov.io/gh/apache/openwhisk/pull/4991?src=pr&el=h1) Report
> :exclamation: No coverage uploaded for pull request base (`master@ef55353`). [Click here to learn what that means](https://docs.codecov.io/docs/error-reference#section-missing-base-commit).
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/openwhisk/pull/4991?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #4991 +/- ##
=========================================
Coverage ? 76.31%
=========================================
Files ? 202
Lines ? 9802
Branches ? 400
=========================================
Hits ? 7480
Misses ? 2322
Partials ? 0
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/openwhisk/pull/4991?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/openwhisk/pull/4991?src=pr&el=footer). Last update [ef55353...66f85aa](https://codecov.io/gh/apache/openwhisk/pull/4991?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [openwhisk] shazron edited a comment on pull request #4991: fix: add new Windows docker.exe location
Posted by GitBox <gi...@apache.org>.
shazron edited a comment on pull request #4991:
URL: https://github.com/apache/openwhisk/pull/4991#issuecomment-704675573
The tests pass now (I fixed the Scala formatting).
For reference for others, to fix Scala formatting issues:
```
./gradelw scalaFmt
# should pass now
./gradlew checkScalaFmt
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [openwhisk] rabbah merged pull request #4991: fix: add new Windows docker.exe location
Posted by GitBox <gi...@apache.org>.
rabbah merged pull request #4991:
URL: https://github.com/apache/openwhisk/pull/4991
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [openwhisk] shazron edited a comment on pull request #4991: fix: add new Windows docker.exe location
Posted by GitBox <gi...@apache.org>.
shazron edited a comment on pull request #4991:
URL: https://github.com/apache/openwhisk/pull/4991#issuecomment-704675573
The tests pass now (I fixed the Scala formatting).
For reference for others, to fix Scala formatting issues:
```
./gradlew scalaFmt
# should pass now
./gradlew checkScalaFmt
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org