[jira] [Commented] (KAFKA-1772) Add an Admin message type for request response

["Joe Stein (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/KAFKA-1772?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14229799#comment-14229799 ] 

Joe Stein commented on KAFKA-1772:
----------------------------------

1) agreed
2) I think we can do away with the "format" field. If we use JSON or by structures it will be one or the other and not both and structured so no need to have which as an option.
3) Yes, lets document the message format(s) in the main section https://cwiki.apache.org/confluence/display/KAFKA/Kafka+Command+Line+and+Related+Improvements
4) We definitely need to support response right away and polling for status. It might be best to just do this for all of the commands and never block at the broker and keep a single pattern at the wire. The layer above the calls will definitely want/need a --sync type option which should be completely in the CLI (IMHO) to loop the check status (every few ms (configurable overridden)) and in some cases (like topic related) to be default because that is experience now. We could also have some be blocking some not.

> Add an Admin message type for request response
> ----------------------------------------------
>
>                 Key: KAFKA-1772
>                 URL: https://issues.apache.org/jira/browse/KAFKA-1772
>             Project: Kafka
>          Issue Type: Sub-task
>            Reporter: Joe Stein
>            Assignee: Andrii Biletskyi
>             Fix For: 0.8.3
>
>         Attachments: KAFKA-1772.patch
>
>
> - utility int8
> - command int8
> - format int8
> - args variable length bytes
> utility 
> 0 - Broker
> 1 - Topic
> 2 - Replication
> 3 - Controller
> 4 - Consumer
> 5 - Producer
> Command
> 0 - Create
> 1 - Alter
> 3 - Delete
> 4 - List
> 5 - Audit
> format
> 0 - JSON
> args e.g. (which would equate to the data structure values == 2,1,0)
> "meta-store": {
> {"zookeeper":"localhost:12913/kafka"}
> }"args": {
>  "partitions":
>   [
>     {"topic": "topic1", "partition": "0"},
>     {"topic": "topic1", "partition": "1"},
>     {"topic": "topic1", "partition": "2"},
>  
>     {"topic": "topic2", "partition": "0"},
>     {"topic": "topic2", "partition": "1"},
>   ]
> }



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)