You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@netbeans.apache.org by "wintama-roberto (via GitHub)" <gi...@apache.org> on 2025/10/17 12:02:11 UTC
[PR] Fixed RequestProcessor FixedRateTask initialDelay [netbeans]
wintama-roberto opened a new pull request, #8932:
URL: https://github.com/apache/netbeans/pull/8932
FixedRateTask using the time unit converted initial delay
---
<details open>
<summary>Click to collapse/expand PR instructions</summary>
By opening a pull request you confirm that, unless explicitly stated otherwise, the changes -
- are all your own work, and you have the right to contribute them.
- are contributed solely under the terms and conditions of the Apache License 2.0 (see section 5 of the license for more information).
Please make sure (eg. `git log`) that all commits have a valid name and email address for you in the Author field.
If you're a first time contributor, see the Contributing guidelines for more information.
If you're a committer, please label the PR before pressing "Create pull request" so that the right test jobs can run.
### PR approval and merge checklist:
1. [ ] Was this PR [correctly labeled](https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=240884239#PRsandYouAreviewerGuide-PRtriggeredCIJobs(conditionalCIpipeline)), did the right tests run? When did they run?
2. [ ] Is this PR [squashed](https://cwiki.apache.org/confluence/display/NETBEANS/git%3A+squash+and+merge)?
3. [ ] Are author name / email address correct? Are [co-authors](https://docs.github.com/en/pull-requests/committing-changes-to-your-project/creating-and-editing-commits/creating-a-commit-with-multiple-authors#creating-co-authored-commits-on-the-command-line) correctly listed? Do the commit messages need updates?
3. [ ] Does the PR title and description still fit after the Nth iteration? Is the description sufficient to appear in the release notes?
If this PR targets the delivery branch: [don't merge](https://cwiki.apache.org/confluence/display/NETBEANS/Pull+requests+for+delivery). ([full wiki article](https://cwiki.apache.org/confluence/display/NETBEANS/PRs+and+You+-+A+reviewer+Guide))
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: [PR] Fixed RequestProcessor FixedRateTask initialDelay [netbeans]
Posted by "mbien (via GitHub)" <gi...@apache.org>.
mbien merged PR #8932:
URL: https://github.com/apache/netbeans/pull/8932
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: [PR] Fixed RequestProcessor FixedRateTask initialDelay [netbeans]
Posted by "mbien (via GitHub)" <gi...@apache.org>.
mbien commented on PR #8932:
URL: https://github.com/apache/netbeans/pull/8932#issuecomment-3416774967
> I directly commited in github, I hoped github will add the author and mail to the commit automatically. Let me check...
We basically require a full author name and a valid email address for contributions. The `noreply` mail is caused due to github settings which allow github to hide your mail.
you can check it by looking at the patch file of the commit:
https://github.com/apache/netbeans/pull/8932.path
to fix this, you will have to amend the commit and force push into the PR branch. (but first check if it looks ok locally with `git log`)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: [PR] Fixed RequestProcessor FixedRateTask initialDelay [netbeans]
Posted by "mbien (via GitHub)" <gi...@apache.org>.
mbien commented on PR #8932:
URL: https://github.com/apache/netbeans/pull/8932#issuecomment-3446679723
@wintama-roberto thanks for fixing this bug which managed to stay hidden for so long (15 years) and congrats on your first NetBeans contribution!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: [PR] Fixed RequestProcessor FixedRateTask initialDelay [netbeans]
Posted by "mbien (via GitHub)" <gi...@apache.org>.
mbien commented on PR #8932:
URL: https://github.com/apache/netbeans/pull/8932#issuecomment-3416369711
hmm. the missing conversion was there since the code was introduced ([archive](https://github.com/emilianbold/netbeans-releases/commit/8f2e314650ed0cd394a5b7de474a47f72b938a4a)). Enabled all tests and targeted NB 29. Although this looks correct on first glance, this could have side effects in case something compensated for it and indirectly relies on this bug.
(Before this can be merged, you would have to update your author and email on the commit though)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: [PR] Fixed RequestProcessor FixedRateTask initialDelay [netbeans]
Posted by "mbien (via GitHub)" <gi...@apache.org>.
mbien commented on PR #8932:
URL: https://github.com/apache/netbeans/pull/8932#issuecomment-3419383907
will probably merge in ~ a week or so. giving others time to chime in.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: [PR] Fixed RequestProcessor FixedRateTask initialDelay [netbeans]
Posted by "wintama-roberto (via GitHub)" <gi...@apache.org>.
wintama-roberto commented on PR #8932:
URL: https://github.com/apache/netbeans/pull/8932#issuecomment-3416848407
Yes, it was private. I have updated the commit author and mail.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: [PR] Fixed RequestProcessor FixedRateTask initialDelay [netbeans]
Posted by "wintama-roberto (via GitHub)" <gi...@apache.org>.
wintama-roberto commented on PR #8932:
URL: https://github.com/apache/netbeans/pull/8932#issuecomment-3416733180
Yes, I was also surprised that this bug was not detected for so long time.
Maybe because for the first execution the delay is correct, as it will be scheduled here:
https://github.com/apache/netbeans/pull/8932/commits/cfe7e0bab30b197fc38f6704580168558c0d9479#diff-772c41d04de094a38f69e278dbe23008634fc40b89f589d4f9ce4fef091eb393R1036
But after that it will be always executed twice, for a while (until the calculation is correct again). Which is - I assume - for most implementations worse than just having a shorter first delay.
If I’d compensate for the bug, I would have just used milliseconds for the timeUnit and both values. But of course, there is no guarantee someone just converted the initialDelay argument to milliseconds and passed another time unit value to the delay. Nevertheless, I think the bug should be fixed, as anyone would expect that it behaves like documented.
I directly commited in github, I hoped github will add the author and mail to the commit automatically. Let me check...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists