You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@commons.apache.org by "arturobernalg (via GitHub)" <gi...@apache.org> on 2023/02/03 17:59:29 UTC

[GitHub] [commons-lang] arturobernalg opened a new pull request, #1026: Use (

) to split the text to different paragraphs in Javadoc comments.

arturobernalg opened a new pull request, #1026:
URL: https://github.com/apache/commons-lang/pull/1026

   See https://www.oracle.com/technical-resources/articles/java/javadoc-tool.html#format


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [commons-lang] garydgregory commented on a diff in pull request #1026: Use (

) to split the text to different paragraphs in Javadoc comments.

Posted by "garydgregory (via GitHub)" <gi...@apache.org>.
garydgregory commented on code in PR #1026:
URL: https://github.com/apache/commons-lang/pull/1026#discussion_r1096285475


##########
src/main/java/org/apache/commons/lang3/ObjectUtils.java:
##########
@@ -984,7 +984,7 @@ public static boolean isArray(final Object object) {
 
     /**
      * Checks if an Object is empty or null.
-     *
+     * <p></p>

Review Comment:
   Uh?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [commons-lang] arturobernalg closed pull request #1026: Use (

) to split the text to different paragraphs in Javadoc comments.

Posted by "arturobernalg (via GitHub)" <gi...@apache.org>.
arturobernalg closed pull request #1026: Use (<p>) to split the text to different paragraphs in Javadoc comments.
URL: https://github.com/apache/commons-lang/pull/1026


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [commons-lang] arturobernalg commented on pull request #1026: Use (

) to split the text to different paragraphs in Javadoc comments.

Posted by "arturobernalg (via GitHub)" <gi...@apache.org>.
arturobernalg commented on PR #1026:
URL: https://github.com/apache/commons-lang/pull/1026#issuecomment-1416329491

   > @arturobernalg Close HTML tags please.
   
   why? 
   its just a paragraph separator.
   
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [commons-lang] garydgregory commented on pull request #1026: Use (

) to split the text to different paragraphs in Javadoc comments.

Posted by "garydgregory (via GitHub)" <gi...@apache.org>.
garydgregory commented on PR #1026:
URL: https://github.com/apache/commons-lang/pull/1026#issuecomment-1416232987

   @arturobernalg Close HTML tags please.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [commons-lang] arturobernalg commented on pull request #1026: Use (

) to split the text to different paragraphs in Javadoc comments.

Posted by "arturobernalg (via GitHub)" <gi...@apache.org>.
arturobernalg commented on PR #1026:
URL: https://github.com/apache/commons-lang/pull/1026#issuecomment-1416373612

   > It is cleaner to follow the same element tag rules everywhere and close all tags.
   
   ok, so I do something like ```<p></p>```??


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [commons-lang] garydgregory commented on a diff in pull request #1026: Use (

) to split the text to different paragraphs in Javadoc comments.

Posted by "garydgregory (via GitHub)" <gi...@apache.org>.
garydgregory commented on code in PR #1026:
URL: https://github.com/apache/commons-lang/pull/1026#discussion_r1096376577


##########
src/main/java/org/apache/commons/lang3/ObjectUtils.java:
##########
@@ -984,7 +984,7 @@ public static boolean isArray(final Object object) {
 
     /**
      * Checks if an Object is empty or null.
-     *
+     * <p></p>

Review Comment:
   Did you not see my example?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [commons-lang] arturobernalg commented on pull request #1026: Use (

) to split the text to different paragraphs in Javadoc comments.

Posted by "arturobernalg (via GitHub)" <gi...@apache.org>.
arturobernalg commented on PR #1026:
URL: https://github.com/apache/commons-lang/pull/1026#issuecomment-1416394039

   > > > It is cleaner to follow the same element tag rules everywhere and close all tags.
   > > 
   > > 
   > > ok, so I do something like `<p></p>`??
   > 
   > Yes, just like any other tag like em, code, pre, and so on.
   
   done


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [commons-lang] garydgregory commented on pull request #1026: Use (

) to split the text to different paragraphs in Javadoc comments.

Posted by "garydgregory (via GitHub)" <gi...@apache.org>.
garydgregory commented on PR #1026:
URL: https://github.com/apache/commons-lang/pull/1026#issuecomment-1416387612

   > > It is cleaner to follow the same element tag rules everywhere and close all tags.
   > 
   > ok, so I do something like `<p></p>`??
   
   Yes, just like any other tag like em, code, pre, and so on.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [commons-lang] codecov-commenter commented on pull request #1026: Use (

) to split the text to different paragraphs in Javadoc comments.

Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #1026:
URL: https://github.com/apache/commons-lang/pull/1026#issuecomment-1416219254

   # [Codecov](https://codecov.io/gh/apache/commons-lang/pull/1026?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#1026](https://codecov.io/gh/apache/commons-lang/pull/1026?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (4e6d21c) into [master](https://codecov.io/gh/apache/commons-lang/commit/ed72275376727cc00f0a3173d2e70cff6579b1b0?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (ed72275) will **not change** coverage.
   > The diff coverage is `n/a`.
   
   ```diff
   @@            Coverage Diff            @@
   ##             master    #1026   +/-   ##
   =========================================
     Coverage     92.03%   92.03%           
     Complexity     7429     7429           
   =========================================
     Files           193      193           
     Lines         15672    15672           
     Branches       2899     2899           
   =========================================
     Hits          14423    14423           
     Misses          676      676           
     Partials        573      573           
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/commons-lang/pull/1026?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [...ain/java/org/apache/commons/lang3/ObjectUtils.java](https://codecov.io/gh/apache/commons-lang/pull/1026?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2NvbW1vbnMvbGFuZzMvT2JqZWN0VXRpbHMuamF2YQ==) | `94.02% <ø> (ø)` | |
   | [...main/java/org/apache/commons/lang3/RegExUtils.java](https://codecov.io/gh/apache/commons-lang/pull/1026?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2NvbW1vbnMvbGFuZzMvUmVnRXhVdGlscy5qYXZh) | `95.23% <ø> (ø)` | |
   | [...va/org/apache/commons/lang3/StringEscapeUtils.java](https://codecov.io/gh/apache/commons-lang/pull/1026?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2NvbW1vbnMvbGFuZzMvU3RyaW5nRXNjYXBlVXRpbHMuamF2YQ==) | `98.90% <ø> (ø)` | |
   | [...ain/java/org/apache/commons/lang3/StringUtils.java](https://codecov.io/gh/apache/commons-lang/pull/1026?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2NvbW1vbnMvbGFuZzMvU3RyaW5nVXRpbHMuamF2YQ==) | `98.86% <ø> (ø)` | |
   | [...n/java/org/apache/commons/lang3/builder/IDKey.java](https://codecov.io/gh/apache/commons-lang/pull/1026?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2NvbW1vbnMvbGFuZzMvYnVpbGRlci9JREtleS5qYXZh) | `72.72% <ø> (ø)` | |
   | [...ommons/lang3/compare/ObjectToStringComparator.java](https://codecov.io/gh/apache/commons-lang/pull/1026?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2NvbW1vbnMvbGFuZzMvY29tcGFyZS9PYmplY3RUb1N0cmluZ0NvbXBhcmF0b3IuamF2YQ==) | `100.00% <ø> (ø)` | |
   | [.../org/apache/commons/lang3/reflect/MemberUtils.java](https://codecov.io/gh/apache/commons-lang/pull/1026?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2NvbW1vbnMvbGFuZzMvcmVmbGVjdC9NZW1iZXJVdGlscy5qYXZh) | `81.05% <ø> (ø)` | |
   | [...java/org/apache/commons/lang3/text/StrBuilder.java](https://codecov.io/gh/apache/commons-lang/pull/1026?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2NvbW1vbnMvbGFuZzMvdGV4dC9TdHJCdWlsZGVyLmphdmE=) | `94.46% <ø> (ø)` | |
   | [...che/commons/lang3/text/translate/EntityArrays.java](https://codecov.io/gh/apache/commons-lang/pull/1026?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2NvbW1vbnMvbGFuZzMvdGV4dC90cmFuc2xhdGUvRW50aXR5QXJyYXlzLmphdmE=) | `100.00% <ø> (ø)` | |
   | [...commons/lang3/text/translate/LookupTranslator.java](https://codecov.io/gh/apache/commons-lang/pull/1026?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2NvbW1vbnMvbGFuZzMvdGV4dC90cmFuc2xhdGUvTG9va3VwVHJhbnNsYXRvci5qYXZh) | `96.42% <ø> (ø)` | |
   | ... and [3 more](https://codecov.io/gh/apache/commons-lang/pull/1026?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
   
   :mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [commons-lang] garydgregory commented on a diff in pull request #1026: Use (

) to split the text to different paragraphs in Javadoc comments.

Posted by "garydgregory (via GitHub)" <gi...@apache.org>.
garydgregory commented on code in PR #1026:
URL: https://github.com/apache/commons-lang/pull/1026#discussion_r1096376936


##########
src/main/java/org/apache/commons/lang3/ObjectUtils.java:
##########
@@ -984,7 +984,7 @@ public static boolean isArray(final Object object) {
 
     /**
      * Checks if an Object is empty or null.
-     *
+     * <p></p>

Review Comment:
   Are you not trying a local build before you push to git?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [commons-lang] garydgregory commented on a diff in pull request #1026: Use (

) to split the text to different paragraphs in Javadoc comments.

Posted by "garydgregory (via GitHub)" <gi...@apache.org>.
garydgregory commented on code in PR #1026:
URL: https://github.com/apache/commons-lang/pull/1026#discussion_r1096817881


##########
src/main/java/org/apache/commons/lang3/ObjectUtils.java:
##########
@@ -984,7 +984,7 @@ public static boolean isArray(final Object object) {
 
     /**
      * Checks if an Object is empty or null.
-     *
+     * <p></p>

Review Comment:
   @arturobernalg 
   `<p>`This is a paragraph.`</p>`, you can't embed lists per the errors in the build. Again, run a 'mvn' build before you push and you will discover this type of issue without forcing reviewers to ping you for broken builds. TY.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [commons-lang] arturobernalg commented on a diff in pull request #1026: Use (

) to split the text to different paragraphs in Javadoc comments.

Posted by "arturobernalg (via GitHub)" <gi...@apache.org>.
arturobernalg commented on code in PR #1026:
URL: https://github.com/apache/commons-lang/pull/1026#discussion_r1096329366


##########
src/main/java/org/apache/commons/lang3/ObjectUtils.java:
##########
@@ -984,7 +984,7 @@ public static boolean isArray(final Object object) {
 
     /**
      * Checks if an Object is empty or null.
-     *
+     * <p></p>

Review Comment:
   done



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [commons-lang] garydgregory commented on pull request #1026: Use (

) to split the text to different paragraphs in Javadoc comments.

Posted by "garydgregory (via GitHub)" <gi...@apache.org>.
garydgregory commented on PR #1026:
URL: https://github.com/apache/commons-lang/pull/1026#issuecomment-1416371619

   It is cleaner to follow the same element tag rules everywhere and close all tags.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [commons-lang] garydgregory commented on a diff in pull request #1026: Use (

) to split the text to different paragraphs in Javadoc comments.

Posted by "garydgregory (via GitHub)" <gi...@apache.org>.
garydgregory commented on code in PR #1026:
URL: https://github.com/apache/commons-lang/pull/1026#discussion_r1096286608


##########
src/main/java/org/apache/commons/lang3/ObjectUtils.java:
##########
@@ -984,7 +984,7 @@ public static boolean isArray(final Object object) {
 
     /**
      * Checks if an Object is empty or null.
-     *
+     * <p></p>

Review Comment:
   `<p>`This is a paragraph.`</p>`



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org