You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@lucene.apache.org by GitBox <gi...@apache.org> on 2020/05/14 12:33:03 UTC
[GitHub] [lucene-solr] magibney commented on a change in pull request #1507: SOLR-14471: properly apply base replica ordering to last-place shards…
magibney commented on a change in pull request #1507:
URL: https://github.com/apache/lucene-solr/pull/1507#discussion_r425099741
##########
File path: solr/solrj/src/test/org/apache/solr/client/solrj/routing/RequestReplicaListTransformerGeneratorTest.java
##########
@@ -88,6 +88,19 @@ public void replicaTypeAndReplicaBase() {
)
);
+ // Add a PULL replica so that there's a tie for "last place"
+ replicas.add(
+ new Replica(
+ "node4",
Review comment:
Ah yes; fixed, thanks for catching that!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org