You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@trafficserver.apache.org by ig...@apache.org on 2013/07/12 18:31:51 UTC

[1/3] git commit: TS-2002: incompatible operand types

Updated Branches:
  refs/heads/master 0f6165c03 -> a91ed9dbb


TS-2002: incompatible operand types

clang complaint in Main.cc: incompatible operand types
('char' and 'char *')

I'm still not 100% sure why I'm not simply assigning:

    char *rt = (char *) regression_test;

This would probably do the exact same thing as the current logic.


Project: http://git-wip-us.apache.org/repos/asf/trafficserver/repo
Commit: http://git-wip-us.apache.org/repos/asf/trafficserver/commit/a91ed9db
Tree: http://git-wip-us.apache.org/repos/asf/trafficserver/tree/a91ed9db
Diff: http://git-wip-us.apache.org/repos/asf/trafficserver/diff/a91ed9db

Branch: refs/heads/master
Commit: a91ed9dbbce9f3aa0915cc2307096dd374c74773
Parents: e375071
Author: Igor Galić <i....@brainsware.org>
Authored: Fri Jul 12 17:22:57 2013 +0200
Committer: Igor Galić <i....@brainsware.org>
Committed: Fri Jul 12 18:31:25 2013 +0200

----------------------------------------------------------------------
 proxy/Main.cc | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/trafficserver/blob/a91ed9db/proxy/Main.cc
----------------------------------------------------------------------
diff --git a/proxy/Main.cc b/proxy/Main.cc
index e0b1689..bd53e6c 100644
--- a/proxy/Main.cc
+++ b/proxy/Main.cc
@@ -1079,7 +1079,7 @@ struct RegressionCont: public Continuation
       printf("Regression waiting for the cache to be ready... %d\n", ++waits);
       return EVENT_CONT;
     }
-    char *rt = (char *) (regression_test[0] == '\0' ? '\0' : regression_test);
+    char *rt = (char *) (regression_test[0] == 0 ? "" : regression_test);
     if (!initialized && RegressionTest::run(rt) == REGRESSION_TEST_INPROGRESS) {
       initialized = 1;
       return EVENT_CONT;


[2/3] git commit: TS-2001: logical only applied to left side of comparison

Posted by ig...@apache.org.
TS-2001: logical only applied to left side of comparison

clang complaint: logical not is only applied to the left hand side of
this comparison
so we simplify.


Project: http://git-wip-us.apache.org/repos/asf/trafficserver/repo
Commit: http://git-wip-us.apache.org/repos/asf/trafficserver/commit/e3750711
Tree: http://git-wip-us.apache.org/repos/asf/trafficserver/tree/e3750711
Diff: http://git-wip-us.apache.org/repos/asf/trafficserver/diff/e3750711

Branch: refs/heads/master
Commit: e37507112070a8566e1de0538c3df5a2d62d925c
Parents: 929f041
Author: Igor Galić <i....@brainsware.org>
Authored: Fri Jul 12 17:20:52 2013 +0200
Committer: Igor Galić <i....@brainsware.org>
Committed: Fri Jul 12 18:31:25 2013 +0200

----------------------------------------------------------------------
 proxy/http/HttpTransact.cc | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/trafficserver/blob/e3750711/proxy/http/HttpTransact.cc
----------------------------------------------------------------------
diff --git a/proxy/http/HttpTransact.cc b/proxy/http/HttpTransact.cc
index fafb927..74580cb 100644
--- a/proxy/http/HttpTransact.cc
+++ b/proxy/http/HttpTransact.cc
@@ -5178,7 +5178,7 @@ HttpTransact::RequestError_t HttpTransact::check_request_validity(State* s, HTTP
     if ((scheme == URL_WKSIDX_HTTP || scheme == URL_WKSIDX_HTTPS) &&
         (method == HTTP_WKSIDX_POST || method == HTTP_WKSIDX_PUSH || method == HTTP_WKSIDX_PUT) &&
         ! incoming_hdr->presence(MIME_PRESENCE_CONTENT_LENGTH) &&
-        ! s->client_info.transfer_encoding == CHUNKED_ENCODING) {
+        s->client_info.transfer_encoding != CHUNKED_ENCODING) {
 
           return NO_POST_CONTENT_LENGTH;
     }


[3/3] git commit: TS-2000: fix a typo in MgmtSchema

Posted by ig...@apache.org.
TS-2000: fix a typo in MgmtSchema

clang complaint: '_MGMT_SCHEMA_' is defined here; did you mean
'__MGMT_SCHEMA_'?
Yes, yes we did mean that.


Project: http://git-wip-us.apache.org/repos/asf/trafficserver/repo
Commit: http://git-wip-us.apache.org/repos/asf/trafficserver/commit/929f0418
Tree: http://git-wip-us.apache.org/repos/asf/trafficserver/tree/929f0418
Diff: http://git-wip-us.apache.org/repos/asf/trafficserver/diff/929f0418

Branch: refs/heads/master
Commit: 929f04185a2f05c44ff992fe201c095e612f4b5d
Parents: 0f6165c
Author: Igor Galić <i....@brainsware.org>
Authored: Fri Jul 12 17:17:50 2013 +0200
Committer: Igor Galić <i....@brainsware.org>
Committed: Fri Jul 12 18:31:25 2013 +0200

----------------------------------------------------------------------
 mgmt/utils/MgmtSchema.h | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/trafficserver/blob/929f0418/mgmt/utils/MgmtSchema.h
----------------------------------------------------------------------
diff --git a/mgmt/utils/MgmtSchema.h b/mgmt/utils/MgmtSchema.h
index fc6e4ee..77f591f 100644
--- a/mgmt/utils/MgmtSchema.h
+++ b/mgmt/utils/MgmtSchema.h
@@ -22,7 +22,7 @@
  */
 
 #ifndef __MGMT_SCHEMA_
-#define _MGMT_SCHEMA_
+#define __MGMT_SCHEMA_
 
 /****************************************************************************
  *
@@ -54,4 +54,4 @@
 bool validateRecordsConfig(XMLNode * node);
 bool validateNode(XMLNode * node);
 
-#endif // _MGMT_SCHEMA
+#endif // __MGMT_SCHEMA