You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Santhosh Edukulla <sa...@citrix.com> on 2014/07/22 04:42:46 UTC
Review Request 23750: Fixed Coverity Reported Issues
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23750/
-----------------------------------------------------------
Review request for cloudstack, daan Hoogland, Koushik Das, and Hugo Trippaers.
Bugs: coverity
https://issues.apache.org/jira/browse/coverity
Repository: cloudstack-git
Description
-------
Fixed Coverity Reported issues under various categories.
Diffs
-----
api/src/org/apache/cloudstack/api/command/user/vm/DeployVMCmd.java 1beb595
engine/schema/src/com/cloud/storage/dao/VMTemplatePoolDaoImpl.java 12a0921
engine/schema/src/com/cloud/upgrade/dao/Upgrade440to450.java caf3b42
engine/storage/src/org/apache/cloudstack/storage/endpoint/DefaultEndPointSelector.java f06b43e
engine/storage/volume/src/org/apache/cloudstack/storage/volume/VolumeServiceImpl.java 3fc43ea
plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/BridgeVifDriver.java e684b8d
server/src/com/cloud/api/ApiResponseHelper.java 51122e0
server/src/com/cloud/api/doc/ApiXmlDocWriter.java fe07056
server/src/com/cloud/resource/ResourceManagerImpl.java 68c9286
server/src/com/cloud/server/ConfigurationServerImpl.java 7c3b5a5
utils/src/com/cloud/utils/nio/NioClient.java 34d03c2
Diff: https://reviews.apache.org/r/23750/diff/
Testing
-------
Built the Management Server, deployed a Data Center using Simulator.
Thanks,
Santhosh Edukulla
Re: Review Request 23750: Fixed Coverity Reported Issues
Posted by Daan Hoogland <da...@gmail.com>.
Santhosh, these coverity findings should unveil hidden regression
possibilities and that's alright. I think you should just commit them
with a marker like 'coverity:'. we'll have to deal with the
regressions when we encounter them (and write appropriate unit tests
as they come along)
On Tue, Jul 22, 2014 at 10:07 AM, Santhosh Edukulla
<sa...@citrix.com> wrote:
>
>
>> On July 22, 2014, 8:01 a.m., Hugo Trippaers wrote:
>> > Santosh, you can commit this directly right? Just make individual commits of each file/component so its easy to track down any issues later.
>
> Sure, i will commit, but please do a review and i want to be sure that no regression issues are added.
>
>
> - Santhosh
>
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23750/#review48350
> -----------------------------------------------------------
>
>
> On July 22, 2014, 2:42 a.m., Santhosh Edukulla wrote:
>>
>> -----------------------------------------------------------
>> This is an automatically generated e-mail. To reply, visit:
>> https://reviews.apache.org/r/23750/
>> -----------------------------------------------------------
>>
>> (Updated July 22, 2014, 2:42 a.m.)
>>
>>
>> Review request for cloudstack, daan Hoogland, Koushik Das, and Hugo Trippaers.
>>
>>
>> Bugs: coverity
>> https://issues.apache.org/jira/browse/coverity
>>
>>
>> Repository: cloudstack-git
>>
>>
>> Description
>> -------
>>
>> Fixed Coverity Reported issues under various categories.
>>
>>
>> Diffs
>> -----
>>
>> api/src/org/apache/cloudstack/api/command/user/vm/DeployVMCmd.java 1beb595
>> engine/schema/src/com/cloud/storage/dao/VMTemplatePoolDaoImpl.java 12a0921
>> engine/schema/src/com/cloud/upgrade/dao/Upgrade440to450.java caf3b42
>> engine/storage/src/org/apache/cloudstack/storage/endpoint/DefaultEndPointSelector.java f06b43e
>> engine/storage/volume/src/org/apache/cloudstack/storage/volume/VolumeServiceImpl.java 3fc43ea
>> plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/BridgeVifDriver.java e684b8d
>> server/src/com/cloud/api/ApiResponseHelper.java 51122e0
>> server/src/com/cloud/api/doc/ApiXmlDocWriter.java fe07056
>> server/src/com/cloud/resource/ResourceManagerImpl.java 68c9286
>> server/src/com/cloud/server/ConfigurationServerImpl.java 7c3b5a5
>> utils/src/com/cloud/utils/nio/NioClient.java 34d03c2
>>
>> Diff: https://reviews.apache.org/r/23750/diff/
>>
>>
>> Testing
>> -------
>>
>> Built the Management Server, deployed a Data Center using Simulator.
>>
>>
>> Thanks,
>>
>> Santhosh Edukulla
>>
>>
>
--
Daan
Re: Review Request 23750: Fixed Coverity Reported Issues
Posted by Santhosh Edukulla <sa...@citrix.com>.
> On July 22, 2014, 8:01 a.m., Hugo Trippaers wrote:
> > Santosh, you can commit this directly right? Just make individual commits of each file/component so its easy to track down any issues later.
Sure, i will commit, but please do a review and i want to be sure that no regression issues are added.
- Santhosh
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23750/#review48350
-----------------------------------------------------------
On July 22, 2014, 2:42 a.m., Santhosh Edukulla wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23750/
> -----------------------------------------------------------
>
> (Updated July 22, 2014, 2:42 a.m.)
>
>
> Review request for cloudstack, daan Hoogland, Koushik Das, and Hugo Trippaers.
>
>
> Bugs: coverity
> https://issues.apache.org/jira/browse/coverity
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> Fixed Coverity Reported issues under various categories.
>
>
> Diffs
> -----
>
> api/src/org/apache/cloudstack/api/command/user/vm/DeployVMCmd.java 1beb595
> engine/schema/src/com/cloud/storage/dao/VMTemplatePoolDaoImpl.java 12a0921
> engine/schema/src/com/cloud/upgrade/dao/Upgrade440to450.java caf3b42
> engine/storage/src/org/apache/cloudstack/storage/endpoint/DefaultEndPointSelector.java f06b43e
> engine/storage/volume/src/org/apache/cloudstack/storage/volume/VolumeServiceImpl.java 3fc43ea
> plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/BridgeVifDriver.java e684b8d
> server/src/com/cloud/api/ApiResponseHelper.java 51122e0
> server/src/com/cloud/api/doc/ApiXmlDocWriter.java fe07056
> server/src/com/cloud/resource/ResourceManagerImpl.java 68c9286
> server/src/com/cloud/server/ConfigurationServerImpl.java 7c3b5a5
> utils/src/com/cloud/utils/nio/NioClient.java 34d03c2
>
> Diff: https://reviews.apache.org/r/23750/diff/
>
>
> Testing
> -------
>
> Built the Management Server, deployed a Data Center using Simulator.
>
>
> Thanks,
>
> Santhosh Edukulla
>
>
Re: Review Request 23750: Fixed Coverity Reported Issues
Posted by Hugo Trippaers <ht...@schubergphilis.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23750/#review48350
-----------------------------------------------------------
Santosh, you can commit this directly right? Just make individual commits of each file/component so its easy to track down any issues later.
- Hugo Trippaers
On July 22, 2014, 2:42 a.m., Santhosh Edukulla wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23750/
> -----------------------------------------------------------
>
> (Updated July 22, 2014, 2:42 a.m.)
>
>
> Review request for cloudstack, daan Hoogland, Koushik Das, and Hugo Trippaers.
>
>
> Bugs: coverity
> https://issues.apache.org/jira/browse/coverity
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> Fixed Coverity Reported issues under various categories.
>
>
> Diffs
> -----
>
> api/src/org/apache/cloudstack/api/command/user/vm/DeployVMCmd.java 1beb595
> engine/schema/src/com/cloud/storage/dao/VMTemplatePoolDaoImpl.java 12a0921
> engine/schema/src/com/cloud/upgrade/dao/Upgrade440to450.java caf3b42
> engine/storage/src/org/apache/cloudstack/storage/endpoint/DefaultEndPointSelector.java f06b43e
> engine/storage/volume/src/org/apache/cloudstack/storage/volume/VolumeServiceImpl.java 3fc43ea
> plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/BridgeVifDriver.java e684b8d
> server/src/com/cloud/api/ApiResponseHelper.java 51122e0
> server/src/com/cloud/api/doc/ApiXmlDocWriter.java fe07056
> server/src/com/cloud/resource/ResourceManagerImpl.java 68c9286
> server/src/com/cloud/server/ConfigurationServerImpl.java 7c3b5a5
> utils/src/com/cloud/utils/nio/NioClient.java 34d03c2
>
> Diff: https://reviews.apache.org/r/23750/diff/
>
>
> Testing
> -------
>
> Built the Management Server, deployed a Data Center using Simulator.
>
>
> Thanks,
>
> Santhosh Edukulla
>
>
Re: Review Request 23750: Fixed Coverity Reported Issues
Posted by Santhosh Edukulla <sa...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23750/
-----------------------------------------------------------
(Updated July 22, 2014, 8:34 a.m.)
Review request for cloudstack, daan Hoogland, edison su, Koushik Das, and Hugo Trippaers.
Bugs: coverity
https://issues.apache.org/jira/browse/coverity
Repository: cloudstack-git
Description
-------
Fixed Coverity Reported issues under various categories.
Diffs
-----
api/src/org/apache/cloudstack/api/command/user/vm/DeployVMCmd.java 1beb595
engine/schema/src/com/cloud/storage/dao/VMTemplatePoolDaoImpl.java 12a0921
engine/schema/src/com/cloud/upgrade/dao/Upgrade440to450.java caf3b42
engine/storage/src/org/apache/cloudstack/storage/endpoint/DefaultEndPointSelector.java f06b43e
engine/storage/volume/src/org/apache/cloudstack/storage/volume/VolumeServiceImpl.java 3fc43ea
plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/BridgeVifDriver.java e684b8d
server/src/com/cloud/api/ApiResponseHelper.java 51122e0
server/src/com/cloud/api/doc/ApiXmlDocWriter.java fe07056
server/src/com/cloud/resource/ResourceManagerImpl.java 68c9286
server/src/com/cloud/server/ConfigurationServerImpl.java 7c3b5a5
utils/src/com/cloud/utils/nio/NioClient.java 34d03c2
Diff: https://reviews.apache.org/r/23750/diff/
Testing
-------
Built the Management Server, deployed a Data Center using Simulator.
Thanks,
Santhosh Edukulla