DO NOT REPLY [Bug 13250] - RemoteDelivery mailet should not split messages based on host when using a gateway

[bu...@apache.org]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://nagoya.apache.org/bugzilla/show_bug.cgi?id=13250>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=13250

RemoteDelivery mailet should not split messages based on host when using a gateway





------- Additional Comments From bwalker@studentadvantage.com  2002-10-03 16:05 -------
Created an attachment (id=3336)
CVS diff file containing the code fix for this issue

--
To unsubscribe, e-mail:   <ma...@jakarta.apache.org>
For additional commands, e-mail: <ma...@jakarta.apache.org>

[PATCH] RemoteDelivery mailet should not split messages based on host when using a gateway

["Noel J. Bergman" <no...@devtech.com>]

> http://nagoya.apache.org/bugzilla/show_bug.cgi?id=13250
> RemoteDelivery mailet should not split messages based on host when using a
gateway
> CVS diff file containing the code fix for this issue

Brad, please see http://jakarta.apache.org/james/contribute.html.  Putting
patches into bugzilla tends to be a recipe for having them ignored.  Also,
there are various style conventions to maintain.

Reformatted patch attached (based upon my current code, so it also has the
<debug> config mod).  I have NOT tested Brad's change.  Looks right and
simple, but committers should take care.

Basically the patch does the following.  In RemoteDelivery.service(), we
have code for going through the list of recipients, and splitting them up by
domain.  The patch wraps that code within an if (gatewayServer == null)
condition, and adds (modified for brevity):

    else {
      // Store the mail unaltered for processing by the gateway server
      if (DEBUG) log("Sending mail to <recipients> via <gatewayServer>");
      outgoing.store(mail);  // send mail unaltered
    }

That leaves the mail as a single message for the deliver() method to forward
to the gateway server, rather than splitting it uselessly.

There is one thing that still bothers me, but it can be addressed later.  We
currently split the recipient list based upon the remote domain.  I believe
that we SHOULD split based upon the mail server (MX record).  That would
yield much more efficient virtual host handling.  I think we can defer that
for post-2.1, but am open to other views.

	--- Noel