You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2021/06/21 08:55:55 UTC
[GitHub] [arrow] pitrou commented on a change in pull request #10550: ARROW-13042: [C++] Check that kernel output is fully initialized
pitrou commented on a change in pull request #10550:
URL: https://github.com/apache/arrow/pull/10550#discussion_r655195574
##########
File path: cpp/src/arrow/compute/kernels/hash_aggregate.cc
##########
@@ -442,6 +442,9 @@ struct GrouperImpl : Grouper {
};
struct GrouperFastImpl : Grouper {
+ static constexpr int kBitmapPaddingForSIMD = 64; // bits
+ static constexpr int kPaddingForSIMD = 32; // bytes
Review comment:
Unfortunately I have no idea why precisely though values. Perhaps @michalursa can tell.
##########
File path: cpp/src/arrow/compute/kernels/hash_aggregate.cc
##########
@@ -442,6 +442,9 @@ struct GrouperImpl : Grouper {
};
struct GrouperFastImpl : Grouper {
+ static constexpr int kBitmapPaddingForSIMD = 64; // bits
+ static constexpr int kPaddingForSIMD = 32; // bytes
Review comment:
Unfortunately I have no idea why precisely those values. Perhaps @michalursa can tell.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org