You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2020/06/23 08:46:21 UTC
[GitHub] [pulsar] Huanli-Meng opened a new pull request #7339: [Issue 7032][Doc] Update connector admin CLI for suporting DLQ for sink/source.
Huanli-Meng opened a new pull request #7339:
URL: https://github.com/apache/pulsar/pull/7339
Fix #7032
Update doc for issue #7032 based on the PR #7094
### Motivation
1. Update doc for issue #7032 for supporting DLQ for sink/source.
2: fix legacy link error for `reload` command in "How to use Pulsar connectors" document
### Modifications
1: add options in localrun for sink connector in connector admin CLI.
2: fix legacy link error for `reload` command in "How to use Pulsar connectors" document
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] Jennifer88huang merged pull request #7339: [Issue 7032][Doc] Update connector admin CLI for suporting DLQ for sink/source.
Posted by GitBox <gi...@apache.org>.
Jennifer88huang merged pull request #7339:
URL: https://github.com/apache/pulsar/pull/7339
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] Huanli-Meng commented on a change in pull request #7339: [Issue 7032][Doc] Update connector admin CLI for suporting DLQ for sink/source.
Posted by GitBox <gi...@apache.org>.
Huanli-Meng commented on a change in pull request #7339:
URL: https://github.com/apache/pulsar/pull/7339#discussion_r444593484
##########
File path: site2/docs/io-cli.md
##########
@@ -557,7 +557,9 @@ $ pulsar-admin sinks localrun options
| `--client-auth-plugin` | Client authentication plugin using which function-process can connect to broker.
|`--cpu`|The CPU (in cores) that needs to be allocated per sink instance (applicable only to the Docker runtime).
| `--custom-schema-inputs` | The map of input topics to Schema types or class names (as a JSON string).
-| `--custom-serde-inputs` | The map of input topics to SerDe class names (as a JSON string).
+| `--max-redeliver-count` | Maximum number of times that a message is redelivered before being sent to the dead letter queue.
+| --dead-letter-topic | Name of the dead letter topic where the failing messages are sent.
+|| `--custom-serde-inputs` | The map of input topics to SerDe class names (as a JSON string).
Review comment:
Thanks for your comments, the doc is updated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] jiazhai commented on a change in pull request #7339: [Issue 7032][Doc] Update connector admin CLI for suporting DLQ for sink/source.
Posted by GitBox <gi...@apache.org>.
jiazhai commented on a change in pull request #7339:
URL: https://github.com/apache/pulsar/pull/7339#discussion_r444589813
##########
File path: site2/docs/io-cli.md
##########
@@ -557,7 +557,9 @@ $ pulsar-admin sinks localrun options
| `--client-auth-plugin` | Client authentication plugin using which function-process can connect to broker.
|`--cpu`|The CPU (in cores) that needs to be allocated per sink instance (applicable only to the Docker runtime).
| `--custom-schema-inputs` | The map of input topics to Schema types or class names (as a JSON string).
-| `--custom-serde-inputs` | The map of input topics to SerDe class names (as a JSON string).
+| `--max-redeliver-count` | Maximum number of times that a message is redelivered before being sent to the dead letter queue.
+| --dead-letter-topic | Name of the dead letter topic where the failing messages are sent.
+|| `--custom-serde-inputs` | The map of input topics to SerDe class names (as a JSON string).
Review comment:
`||` => `|`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] Anonymitaet commented on a change in pull request #7339: [Issue 7032][Doc] Update connector admin CLI for suporting DLQ for sink/source.
Posted by GitBox <gi...@apache.org>.
Anonymitaet commented on a change in pull request #7339:
URL: https://github.com/apache/pulsar/pull/7339#discussion_r444867307
##########
File path: site2/docs/io-cli.md
##########
@@ -557,6 +557,8 @@ $ pulsar-admin sinks localrun options
| `--client-auth-plugin` | Client authentication plugin using which function-process can connect to broker.
|`--cpu`|The CPU (in cores) that needs to be allocated per sink instance (applicable only to the Docker runtime).
| `--custom-schema-inputs` | The map of input topics to Schema types or class names (as a JSON string).
+| `--max-redeliver-count` | Maximum number of times that a message is redelivered before being sent to the dead letter queue.
+| `--dead-letter-topic` | Name of the dead letter topic where the failing messages are sent.
Review comment:
failing → failed ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] Huanli-Meng commented on pull request #7339: [Issue 7032][Doc] Update connector admin CLI for suporting DLQ for sink/source.
Posted by GitBox <gi...@apache.org>.
Huanli-Meng commented on pull request #7339:
URL: https://github.com/apache/pulsar/pull/7339#issuecomment-648002193
@Jennifer88huang @jiazhai , could you please help review? Thanks.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] ADHB removed a comment on pull request #7339: [Issue 7032][Doc] Update connector admin CLI for suporting DLQ for sink/source.
Posted by GitBox <gi...@apache.org>.
ADHB removed a comment on pull request #7339:
URL: https://github.com/apache/pulsar/pull/7339#issuecomment-696541504
Hi guys. Thanks for the good work.
When I use Elastic sink with dead_letter_topic i get:
[root@clstpulsar01 apache-pulsar-2.6.1]# bin/pulsar-admin sink create --name elastic --dead_letter_topic test-tenant/test-namespace/elastic_dlq --sink-config-file conf/elastic_sink.yml --tenant test-tenant --namespace test-namespace --inputs netty --archive connectors/pulsar-io-elastic-search-2.6.1.nar
Unknown option: --dead_letter_topic
Any thoughts?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] Huanli-Meng commented on a change in pull request #7339: [Issue 7032][Doc] Update connector admin CLI for suporting DLQ for sink/source.
Posted by GitBox <gi...@apache.org>.
Huanli-Meng commented on a change in pull request #7339:
URL: https://github.com/apache/pulsar/pull/7339#discussion_r444593586
##########
File path: site2/docs/io-cli.md
##########
@@ -557,7 +557,9 @@ $ pulsar-admin sinks localrun options
| `--client-auth-plugin` | Client authentication plugin using which function-process can connect to broker.
|`--cpu`|The CPU (in cores) that needs to be allocated per sink instance (applicable only to the Docker runtime).
| `--custom-schema-inputs` | The map of input topics to Schema types or class names (as a JSON string).
-| `--custom-serde-inputs` | The map of input topics to SerDe class names (as a JSON string).
+| `--max-redeliver-count` | Maximum number of times that a message is redelivered before being sent to the dead letter queue.
+| --dead-letter-topic | Name of the dead letter topic where the failing messages are sent.
Review comment:
Thanks for your comments. The doc is updated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] jiazhai commented on a change in pull request #7339: [Issue 7032][Doc] Update connector admin CLI for suporting DLQ for sink/source.
Posted by GitBox <gi...@apache.org>.
jiazhai commented on a change in pull request #7339:
URL: https://github.com/apache/pulsar/pull/7339#discussion_r444589744
##########
File path: site2/docs/io-cli.md
##########
@@ -557,7 +557,9 @@ $ pulsar-admin sinks localrun options
| `--client-auth-plugin` | Client authentication plugin using which function-process can connect to broker.
|`--cpu`|The CPU (in cores) that needs to be allocated per sink instance (applicable only to the Docker runtime).
| `--custom-schema-inputs` | The map of input topics to Schema types or class names (as a JSON string).
-| `--custom-serde-inputs` | The map of input topics to SerDe class names (as a JSON string).
+| `--max-redeliver-count` | Maximum number of times that a message is redelivered before being sent to the dead letter queue.
+| --dead-letter-topic | Name of the dead letter topic where the failing messages are sent.
Review comment:
`--dead-letter-topic ` add "``"
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] ADHB removed a comment on pull request #7339: [Issue 7032][Doc] Update connector admin CLI for suporting DLQ for sink/source.
Posted by GitBox <gi...@apache.org>.
ADHB removed a comment on pull request #7339:
URL: https://github.com/apache/pulsar/pull/7339#issuecomment-696541504
Hi guys. Thanks for the good work.
When I use Elastic sink with dead_letter_topic i get:
[root@clstpulsar01 apache-pulsar-2.6.1]# bin/pulsar-admin sink create --name elastic --dead_letter_topic test-tenant/test-namespace/elastic_dlq --sink-config-file conf/elastic_sink.yml --tenant test-tenant --namespace test-namespace --inputs netty --archive connectors/pulsar-io-elastic-search-2.6.1.nar
Unknown option: --dead_letter_topic
Any thoughts?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] ADHB commented on pull request #7339: [Issue 7032][Doc] Update connector admin CLI for suporting DLQ for sink/source.
Posted by GitBox <gi...@apache.org>.
ADHB commented on pull request #7339:
URL: https://github.com/apache/pulsar/pull/7339#issuecomment-696541504
Hi guys. Thanks for the good work.
When I use Elastic sink with dead_letter_topic i get:
[root@clstpulsar01 apache-pulsar-2.6.1]# bin/pulsar-admin sink create --name elastic --dead_letter_topic test-tenant/test-namespace/elastic_dlq --sink-config-file conf/elastic_sink.yml --tenant test-tenant --namespace test-namespace --inputs netty --archive connectors/pulsar-io-elastic-search-2.6.1.nar
Unknown option: --dead_letter_topic
Any thoughts?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] ADHB commented on pull request #7339: [Issue 7032][Doc] Update connector admin CLI for suporting DLQ for sink/source.
Posted by GitBox <gi...@apache.org>.
ADHB commented on pull request #7339:
URL: https://github.com/apache/pulsar/pull/7339#issuecomment-696541504
Hi guys. Thanks for the good work.
When I use Elastic sink with dead_letter_topic i get:
[root@clstpulsar01 apache-pulsar-2.6.1]# bin/pulsar-admin sink create --name elastic --dead_letter_topic test-tenant/test-namespace/elastic_dlq --sink-config-file conf/elastic_sink.yml --tenant test-tenant --namespace test-namespace --inputs netty --archive connectors/pulsar-io-elastic-search-2.6.1.nar
Unknown option: --dead_letter_topic
Any thoughts?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org