You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@geode.apache.org by Jason Huynh <jh...@pivotal.io> on 2016/09/08 22:27:01 UTC
Review Request 51734: GEODE-1864: CompactMapRangeIndex not updating
old keys properly
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51734/
-----------------------------------------------------------
Review request for geode, Barry Oglesby and nabarun nag.
Repository: geode
Description
-------
Old keys that are no longer part of a new map, should be removed from the index.
Diffs
-----
geode-core/src/main/java/com/gemstone/gemfire/cache/query/internal/index/CompactMapRangeIndex.java c374a10
geode-core/src/test/java/com/gemstone/gemfire/cache/query/internal/index/MapRangeIndexMaintenanceJUnitTest.java e346522
Diff: https://reviews.apache.org/r/51734/diff/
Testing
-------
Thanks,
Jason Huynh
Re: Review Request 51734: GEODE-1864: CompactMapRangeIndex not
updating old keys properly
Posted by nabarun nag <nn...@pivotal.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51734/#review149905
-----------------------------------------------------------
Ship it!
Ship It!
- nabarun nag
On Sept. 21, 2016, 4 p.m., Jason Huynh wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51734/
> -----------------------------------------------------------
>
> (Updated Sept. 21, 2016, 4 p.m.)
>
>
> Review request for geode, Barry Oglesby and nabarun nag.
>
>
> Repository: geode
>
>
> Description
> -------
>
> Old keys that are no longer part of a new map, should be removed from the index.
>
>
> Diffs
> -----
>
> geode-core/src/main/java/org/apache/geode/cache/query/internal/index/CompactMapRangeIndex.java ce1ea08
> geode-core/src/main/java/org/apache/geode/cache/query/internal/index/CompactRangeIndex.java d5dd5a6
> geode-core/src/test/java/org/apache/geode/cache/query/internal/index/MapRangeIndexMaintenanceJUnitTest.java 9833e43
>
> Diff: https://reviews.apache.org/r/51734/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Jason Huynh
>
>
Re: Review Request 51734: GEODE-1864: CompactMapRangeIndex not
updating old keys properly
Posted by Jason Huynh <jh...@pivotal.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51734/
-----------------------------------------------------------
(Updated Sept. 21, 2016, 4 p.m.)
Review request for geode, Barry Oglesby and nabarun nag.
Changes
-------
GEODE-1864: Updated diff.
GEODE-1745: Additional fix for CompactRangeIndex Reevaluation causing results to be missed when using a MapIndex without an In clause.
Repository: geode
Description
-------
Old keys that are no longer part of a new map, should be removed from the index.
Diffs (updated)
-----
geode-core/src/main/java/org/apache/geode/cache/query/internal/index/CompactMapRangeIndex.java ce1ea08
geode-core/src/main/java/org/apache/geode/cache/query/internal/index/CompactRangeIndex.java d5dd5a6
geode-core/src/test/java/org/apache/geode/cache/query/internal/index/MapRangeIndexMaintenanceJUnitTest.java 9833e43
Diff: https://reviews.apache.org/r/51734/diff/
Testing
-------
Thanks,
Jason Huynh
Re: Review Request 51734: GEODE-1864: CompactMapRangeIndex not
updating old keys properly
Posted by nabarun nag <nn...@pivotal.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51734/#review148584
-----------------------------------------------------------
Ship it!
Ship It!
- nabarun nag
On Sept. 8, 2016, 10:27 p.m., Jason Huynh wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51734/
> -----------------------------------------------------------
>
> (Updated Sept. 8, 2016, 10:27 p.m.)
>
>
> Review request for geode, Barry Oglesby and nabarun nag.
>
>
> Repository: geode
>
>
> Description
> -------
>
> Old keys that are no longer part of a new map, should be removed from the index.
>
>
> Diffs
> -----
>
> geode-core/src/main/java/com/gemstone/gemfire/cache/query/internal/index/CompactMapRangeIndex.java c374a10
> geode-core/src/test/java/com/gemstone/gemfire/cache/query/internal/index/MapRangeIndexMaintenanceJUnitTest.java e346522
>
> Diff: https://reviews.apache.org/r/51734/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Jason Huynh
>
>