[GitHub] [hbase] saintstack commented on a change in pull request #3576: HBASE-26122: Only create ScannerContext for Gets with setMaxResultSize > 0 (ADDENDUM)

[GitBox <gi...@apache.org>]

saintstack commented on a change in pull request #3576:
URL: https://github.com/apache/hbase/pull/3576#discussion_r686905766



##########
File path: hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/RegionScannerImpl.java
##########
@@ -240,6 +240,9 @@ public synchronized boolean next(List<Cell> outResults, ScannerContext scannerCo
     }
     region.startRegionOperation(Operation.SCAN);
     try {
+      if (scannerContext == null) {

Review comment:
       After your finding, it seems like your original PR is the way to go. Thanks for figuring it.
   
   I reverted the branch-2 apply. One thought if you are making a new PR is for the javadoc on setMaxResultSize; you say, 'The user is required to handle this case.'... Perhaps add example of what they might do... i.e. a re-get w/ filter say?
   
   Thanks @bbeaudreault 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org