You are viewing a plain text version of this content. The canonical link for it is here.
Posted to codereview@trafodion.apache.org by luoyunpeng <gi...@git.apache.org> on 2017/07/12 10:19:42 UTC
[GitHub] incubator-trafodion pull request #1175: TRAFODION-2686 fix setCurSorName doe...
GitHub user luoyunpeng opened a pull request:
https://github.com/apache/incubator-trafodion/pull/1175
TRAFODION-2686 fix setCurSorName does not work
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/luoyunpeng/incubator-trafodion setcursorname-fix
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-trafodion/pull/1175.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1175
----
commit a20d74fb8ed21828a96c673ff978fc3c15b3bd17
Author: luoyunpeng <95...@qq.com>
Date: 2017-07-12T10:08:35Z
TRAFODION-2686 fix setCurSorName does not work
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-trafodion pull request #1175: TRAFODION-2686 fix setCurSorName doe...
Posted by selvaganesang <gi...@git.apache.org>.
Github user selvaganesang commented on a diff in the pull request:
https://github.com/apache/incubator-trafodion/pull/1175#discussion_r128053948
--- Diff: core/conn/jdbcT4/src/main/java/org/trafodion/jdbc/t4/TrafT4Statement.java ---
@@ -1247,7 +1247,7 @@ void setMultipleResultSets(int num_result_sets, TrafT4Desc[][] output_descriptor
if (desc == null) {
resultSet_[i] = null;
} else {
- resultSet_[i] = new TrafT4ResultSet(this, desc, stmt_labels[i], true);
+ resultSet_[i] = new TrafT4ResultSet(this, desc, stmt_labels[i], this.sqlStmtType_==TRANSPORT.TYPE_CALL);
--- End diff --
Thanks for the explanation. Read the surrounding the code and it made sense now
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-trafodion pull request #1175: TRAFODION-2686 fix setCurSorName doe...
Posted by selvaganesang <gi...@git.apache.org>.
Github user selvaganesang commented on a diff in the pull request:
https://github.com/apache/incubator-trafodion/pull/1175#discussion_r127723191
--- Diff: core/conn/jdbcT4/src/main/java/org/trafodion/jdbc/t4/TrafT4Statement.java ---
@@ -1247,7 +1247,7 @@ void setMultipleResultSets(int num_result_sets, TrafT4Desc[][] output_descriptor
if (desc == null) {
resultSet_[i] = null;
} else {
- resultSet_[i] = new TrafT4ResultSet(this, desc, stmt_labels[i], true);
+ resultSet_[i] = new TrafT4ResultSet(this, desc, stmt_labels[i], this.sqlStmtType_==TRANSPORT.TYPE_CALL);
--- End diff --
The last parameter seems to denote oldDataFormat in TrafT4ResultSet.java. Can you please provide some explanation about this change?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-trafodion pull request #1175: TRAFODION-2686 fix setCurSorName doe...
Posted by luoyunpeng <gi...@git.apache.org>.
Github user luoyunpeng commented on a diff in the pull request:
https://github.com/apache/incubator-trafodion/pull/1175#discussion_r127860988
--- Diff: core/conn/jdbcT4/src/main/java/org/trafodion/jdbc/t4/TrafT4Statement.java ---
@@ -1247,7 +1247,7 @@ void setMultipleResultSets(int num_result_sets, TrafT4Desc[][] output_descriptor
if (desc == null) {
resultSet_[i] = null;
} else {
- resultSet_[i] = new TrafT4ResultSet(this, desc, stmt_labels[i], true);
+ resultSet_[i] = new TrafT4ResultSet(this, desc, stmt_labels[i], this.sqlStmtType_==TRANSPORT.TYPE_CALL);
--- End diff --
this is the parameter pass to spj_rs which is always true that cause setCursorName in TraT4Statement.java does not work,
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-trafodion pull request #1175: TRAFODION-2686 fix setCurSorName doe...
Posted by luoyunpeng <gi...@git.apache.org>.
Github user luoyunpeng commented on a diff in the pull request:
https://github.com/apache/incubator-trafodion/pull/1175#discussion_r128132482
--- Diff: core/conn/jdbcT4/src/main/java/org/trafodion/jdbc/t4/TrafT4Statement.java ---
@@ -1247,7 +1247,7 @@ void setMultipleResultSets(int num_result_sets, TrafT4Desc[][] output_descriptor
if (desc == null) {
resultSet_[i] = null;
} else {
- resultSet_[i] = new TrafT4ResultSet(this, desc, stmt_labels[i], true);
+ resultSet_[i] = new TrafT4ResultSet(this, desc, stmt_labels[i], this.sqlStmtType_==TRANSPORT.TYPE_CALL);
--- End diff --
Thanks for helping review,
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-trafodion pull request #1175: TRAFODION-2686 fix setCurSorName doe...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-trafodion/pull/1175
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---