You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@lucene.apache.org by "Robert Muir (Jira)" <ji...@apache.org> on 2021/04/07 10:22:00 UTC
[jira] [Resolved] (LUCENE-9882) better synchronize eclipse
formatter with spotless
[ https://issues.apache.org/jira/browse/LUCENE-9882?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Robert Muir resolved LUCENE-9882.
---------------------------------
Fix Version/s: main (9.0)
Resolution: Fixed
> better synchronize eclipse formatter with spotless
> --------------------------------------------------
>
> Key: LUCENE-9882
> URL: https://issues.apache.org/jira/browse/LUCENE-9882
> Project: Lucene - Core
> Issue Type: Task
> Reporter: Robert Muir
> Priority: Major
> Fix For: main (9.0)
>
> Time Spent: 20m
> Remaining Estimate: 0h
>
> Spotless project provides an eclipse .xml format (which is just the properties in xml format) that is pretty close to what its doing.
> Currently, I don't remember where our formatting settings came from. they are pretty close, but if I import the spotless settings in, then it is measurably closer (tested by reformatting entire codebase with eclipse and then looking at diff size)
> Before: 33MB diff
> After: 25MB diff
> Keep in mind the comparison is noise'd up by a lot of generated code and stuff like that, and the formatting match also isn't 100% match, but still seems worth looking into: smoother path for the user.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org