You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/07/10 10:01:49 UTC
[GitHub] [pulsar] BewareMyPower opened a new pull request, #16510: [improve][test] Fix flaky C++ ClientTest.testWrongListener
BewareMyPower opened a new pull request, #16510:
URL: https://github.com/apache/pulsar/pull/16510
Fixes #16509
### Motivation
Since all producers and consumer of the same Client share the same
connection pool, if one failed, the following producer or consumer might
reuse the broken connection and failed with `ResultConnectError`. It
causes the flaky `testWrongListener` because the consumer and reader
would be created after the producer creation failed with
`ResultServiceNotReady`.
### Modifications
Recreate the `Client` for the subsequent creation of `Consumer` and
`Reader` so that new connection pools will be used for them.
There is also a potential bug that makes `Client::shutdown` wait for the
max timeout (3 seconds), this PR also applies the timeout for other
executors.
### Verifying this change
After this change, I've run the following command in my local env and it
never failed.
```bash
# rerun the testWrongListener for 20 times
./tests/main --gtest_filter='ClientTest.testWrongListener' --gtest_repeat=20
```
### Documentation
Check the box below or label this PR directly.
Need to update docs?
- [ ] `doc-required`
(Your PR needs to update docs and you will update later)
- [x] `doc-not-needed`
(Please explain why)
- [ ] `doc`
(Your PR contains doc changes)
- [ ] `doc-complete`
(Docs have been already added)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] codelipenghui merged pull request #16510: [improve][test] Fix flaky C++ ClientTest.testWrongListener
Posted by GitBox <gi...@apache.org>.
codelipenghui merged PR #16510:
URL: https://github.com/apache/pulsar/pull/16510
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] tisonkun commented on pull request #16510: [improve][test] Fix flaky C++ ClientTest.testWrongListener
Posted by GitBox <gi...@apache.org>.
tisonkun commented on PR #16510:
URL: https://github.com/apache/pulsar/pull/16510#issuecomment-1181786077
I noticed that https://github.com/apache/pulsar/pull/16542 got merged and it possibly resolve the flaky Broker Group 1 tests. @BewareMyPower you can merge master to rerun CI tasks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] tisonkun commented on pull request #16510: [improve][test] Fix flaky C++ ClientTest.testWrongListener
Posted by GitBox <gi...@apache.org>.
tisonkun commented on PR #16510:
URL: https://github.com/apache/pulsar/pull/16510#issuecomment-1180059395
> Unit - Brokers - Broker Group 1 is too flaky, I think I need to wait the related fix.
They could be a dead lock, lol.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] BewareMyPower commented on pull request #16510: [improve][test] Fix flaky C++ ClientTest.testWrongListener
Posted by GitBox <gi...@apache.org>.
BewareMyPower commented on PR #16510:
URL: https://github.com/apache/pulsar/pull/16510#issuecomment-1179756044
Unit - Brokers - Broker Group 1 is too flaky, I think I need to wait the related fix.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] github-actions[bot] commented on pull request #16510: [improve][test] Fix flaky C++ ClientTest.testWrongListener
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #16510:
URL: https://github.com/apache/pulsar/pull/16510#issuecomment-1179696648
@BewareMyPower Please provide a correct documentation label for your PR.
Instructions see [Pulsar Documentation Label Guide](https://docs.google.com/document/d/1Qw7LHQdXWBW9t2-r-A7QdFDBwmZh6ytB4guwMoXHqc0).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] tisonkun commented on pull request #16510: [improve][test] Fix flaky C++ ClientTest.testWrongListener
Posted by GitBox <gi...@apache.org>.
tisonkun commented on PR #16510:
URL: https://github.com/apache/pulsar/pull/16510#issuecomment-1180111995
/pulsarbot rerun-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org