[GitHub] [pinot] Jackie-Jiang commented on a diff in pull request #8856: BUGFIX: Adding util for getting URL from InstanceConfig

[GitBox <gi...@apache.org>]

Jackie-Jiang commented on code in PR #8856:
URL: https://github.com/apache/pinot/pull/8856#discussion_r892895428


##########
pinot-common/src/main/java/org/apache/pinot/common/helix/ExtraInstanceConfig.java:
##########
@@ -44,4 +45,42 @@ public String getTlsPort() {
   public void setTlsPort(String tlsPort) {
     _proxy.getRecord().setSimpleField(PinotInstanceConfigProperty.PINOT_TLS_PORT.toString(), tlsPort);
   }
+
+  /**
+   * Returns an instance URL from the InstanceConfig. Will set the appropriate protocol and port.
+   */
+  public String getComponentUrl() {
+    String hostName = _proxy.getHostName();
+    // Backward-compatible with legacy hostname of format 'Controller_<hostname>'

Review Comment:
   I don't think we allow this legacy hostname format though. Do you see example of this legacy format?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org