You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "tustvold (via GitHub)" <gi...@apache.org> on 2023/06/28 17:40:07 UTC

[GitHub] [arrow-rs] tustvold opened a new pull request, #4460: Fix empty offset index for all null columns (#4459)

tustvold opened a new pull request, #4460:
URL: https://github.com/apache/arrow-rs/pull/4460

   # Which issue does this PR close?
   
   <!--
   We generally require a GitHub issue to be filed for all bug fixes and enhancements and this helps us generate change logs for our releases. You can link an issue to this PR using the GitHub syntax. For example `Closes #123` indicates that this PR will close issue #123.
   -->
   
   Closes #4459
   
   # Rationale for this change
    
   <!--
   Why are you proposing this change? If this is already explained clearly in the issue then this section is not needed.
   Explaining clearly why changes are proposed helps reviewers understand your changes and offer better suggestions for fixes.
   -->
   
   # What changes are included in this PR?
   
   <!--
   There is no need to duplicate the description in the issue here but it is sometimes worth providing a summary of the individual changes in this PR.
   -->
   
   # Are there any user-facing changes?
   
   
   <!--
   If there are user-facing changes then we may require documentation to be updated before approving the PR.
   -->
   
   <!---
   If there are any breaking changes to public APIs, please add the `breaking change` label.
   -->
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow-rs] alamb commented on pull request #4460: Fix empty offset index for all null columns (#4459)

Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb commented on PR #4460:
URL: https://github.com/apache/arrow-rs/pull/4460#issuecomment-1611870143

   cc @AdamGS 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow-rs] alamb commented on a diff in pull request #4460: Fix empty offset index for all null columns (#4459)

Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb commented on code in PR #4460:
URL: https://github.com/apache/arrow-rs/pull/4460#discussion_r1245589109


##########
parquet/src/arrow/arrow_writer/mod.rs:
##########
@@ -2609,4 +2610,30 @@ mod tests {
 
         writer.close().unwrap();
     }
+

Review Comment:
   I verified that without the code change in this PR, this test fails like this:
   
   ```
   
   failures:
   
   ---- arrow::arrow_writer::tests::test_writer_all_null stdout ----
   thread 'arrow::arrow_writer::tests::test_writer_all_null' panicked at 'assertion failed: `(left == right)`
     left: `0`,
    right: `1`', parquet/src/arrow/arrow_writer/mod.rs:2637:9
   stack backtrace:
      0: rust_begin_unwind
                at /rustc/90c541806f23a127002de5b4038be731ba1458ca/library/std/src/panicking.rs:578:5
      1: core::panicking::panic_fmt
                at /rustc/90c541806f23a127002de5b4038be731ba1458ca/library/core/src/panicking.rs:67:14
      2: core::panicking::assert_failed_inner
                at /rustc/90c541806f23a127002de5b4038be731ba1458ca/library/core/src/panicking.rs:274:17
      3: core::panicking::assert_failed
                at /rustc/90c541806f23a127002de5b4038be731ba1458ca/library/core/src/panicking.rs:228:5
      4: parquet::arrow::arrow_writer::tests::test_writer_all_null
                at ./src/arrow/arrow_writer/mod.rs:2637:9
      5: parquet::arrow::arrow_writer::tests::test_writer_all_null::{{closure}}
                at ./src/arrow/arrow_writer/mod.rs:2615:31
      6: core::ops::function::FnOnce::call_once
                at /rustc/90c541806f23a127002de5b4038be731ba1458ca/library/core/src/ops/function.rs:250:5
      7: core::ops::function::FnOnce::call_once
                at /rustc/90c541806f23a127002de5b4038be731ba1458ca/library/core/src/ops/function.rs:250:5
   note: Some details are omitted, run with `RUST_BACKTRACE=full` for a verbose backtrace.
   
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow-rs] tustvold merged pull request #4460: Fix empty offset index for all null columns (#4459)

Posted by "tustvold (via GitHub)" <gi...@apache.org>.
tustvold merged PR #4460:
URL: https://github.com/apache/arrow-rs/pull/4460


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org