You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by cloud-fan <gi...@git.apache.org> on 2017/12/05 15:01:21 UTC
[GitHub] spark pull request #19898: [SPARK-22703][SQL] make ColumnarRow an immutable ...
GitHub user cloud-fan opened a pull request:
https://github.com/apache/spark/pull/19898
[SPARK-22703][SQL] make ColumnarRow an immutable view
## What changes were proposed in this pull request?
Similar to https://github.com/apache/spark/pull/19842 , we should also make `ColumnarRow` an immutable view, and move forward to make `ColumnVector` public.
## How was this patch tested?
Existing tests.
The performance concern should be same as https://github.com/apache/spark/pull/19842 .
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/cloud-fan/spark row-id
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/19898.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #19898
----
----
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #19898: [SPARK-22703][SQL] make ColumnarRow an immutable view
Posted by ueshin <gi...@git.apache.org>.
Github user ueshin commented on the issue:
https://github.com/apache/spark/pull/19898
LGTM.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #19898: [SPARK-22703][SQL] make ColumnarRow an immutable view
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19898
**[Test build #84488 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84488/testReport)** for PR 19898 at commit [`0771ffc`](https://github.com/apache/spark/commit/0771ffc3b298d909aa3f5fc3c6acb1e6ca2b2545).
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #19898: [SPARK-22703][SQL] make ColumnarRow an immutable view
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19898
Merged build finished. Test PASSed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request #19898: [SPARK-22703][SQL] make ColumnarRow an immutable ...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/19898
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #19898: [SPARK-22703][SQL] make ColumnarRow an immutable view
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19898
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/84488/
Test PASSed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #19898: [SPARK-22703][SQL] make ColumnarRow an immutable view
Posted by cloud-fan <gi...@git.apache.org>.
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/19898
cc @ueshin @hvanhovell @kiszk @gatorsmile
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #19898: [SPARK-22703][SQL] make ColumnarRow an immutable view
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19898
**[Test build #84488 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84488/testReport)** for PR 19898 at commit [`0771ffc`](https://github.com/apache/spark/commit/0771ffc3b298d909aa3f5fc3c6acb1e6ca2b2545).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #19898: [SPARK-22703][SQL] make ColumnarRow an immutable view
Posted by cloud-fan <gi...@git.apache.org>.
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/19898
thanks, merging to master!
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org