[GitHub] [solr] HoustonPutman commented on pull request #1730: SOLR-16855: Add a MigrateReplicas API

["HoustonPutman (via GitHub)" <gi...@apache.org>]

HoustonPutman commented on PR #1730:
URL: https://github.com/apache/solr/pull/1730#issuecomment-1613684901

   So I found a bug, or room for improvement, in the orderedNodePlacementPlugin code due to one of the tests. Basically it will do a greedy lookup to find the best node for each new replica type. However, an un-optimal ordering of the replicas being placed can result in an un-optimal set of placements. Its hard to make this logic fool-proof, without blowing up the computation time. But I've come up with a "hack", not really, but it's only fixes a subset of the un-optimal cases, that we can have that works for now.
   
   We'll need to make the OrderedNodePlacementPlugin smarter to make all cases optimal, or at least closer to optimal. 
   But this can be done separately as an optimization in the future.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org