You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Sam Schmit <sa...@appcore.com> on 2014/05/05 23:44:39 UTC
Review Request 21088: CLOUDSTACK-6472 (4.3-specific) listUsageRecords: Pull
information from removed items as well,
fixing NPEs/Null UUIDs with usage API calls.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21088/
-----------------------------------------------------------
Review request for cloudstack.
Bugs: CLOUDSTACK-6472
https://issues.apache.org/jira/browse/CLOUDSTACK-6472
Repository: cloudstack-git
Description
-------
Running "listUsageRecords" when there were any destroyed/expunged Virtual Machines would return errors (on 4.3) or return null UUIDs (on master). The UUID is important for correlating records.
Diffs
-----
server/src/com/cloud/api/ApiResponseHelper.java a8bef47
utils/src/com/cloud/utils/db/EntityManager.java d613d7d
Diff: https://reviews.apache.org/r/21088/diff/
Testing
-------
1) Created virtual machine
2) Ran usage
3) ran "listUsageRecords" API call, successful data returned
4) Expunged VM
5) Ran usage
6) ran "listUsageRecords" API call, successful data returned (this would previously return an error)
Thanks,
Sam Schmit
Re: Review Request 21088: CLOUDSTACK-6472 (4.3-specific) listUsageRecords:
Pull information from removed items as well,
fixing NPEs/Null UUIDs with usage API calls.
Posted by ASF Subversion and Git Services <as...@urd.zones.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21088/#review42273
-----------------------------------------------------------
Commit e8047e11db7ef2bdc44bbedfdc47e63c55f080c5 in cloudstack's branch refs/heads/4.3 from Sam Schmit
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=e8047e1 ]
CLOUDSTACK-6472 (4.3 specific) listUsageRecords: Pull information from removed items as well, fixing NPEs/Null UUIDs with usage API calls.
Signed-off-by: Sebastien Goasguen <ru...@gmail.com>
- ASF Subversion and Git Services
On May 5, 2014, 9:44 p.m., Sam Schmit wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/21088/
> -----------------------------------------------------------
>
> (Updated May 5, 2014, 9:44 p.m.)
>
>
> Review request for cloudstack.
>
>
> Bugs: CLOUDSTACK-6472
> https://issues.apache.org/jira/browse/CLOUDSTACK-6472
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> Running "listUsageRecords" when there were any destroyed/expunged Virtual Machines would return errors (on 4.3) or return null UUIDs (on master). The UUID is important for correlating records.
>
>
> Diffs
> -----
>
> server/src/com/cloud/api/ApiResponseHelper.java a8bef47
> utils/src/com/cloud/utils/db/EntityManager.java d613d7d
>
> Diff: https://reviews.apache.org/r/21088/diff/
>
>
> Testing
> -------
>
> 1) Created virtual machine
> 2) Ran usage
> 3) ran "listUsageRecords" API call, successful data returned
> 4) Expunged VM
> 5) Ran usage
> 6) ran "listUsageRecords" API call, successful data returned (this would previously return an error)
>
>
> Thanks,
>
> Sam Schmit
>
>
Re: Review Request 21088: CLOUDSTACK-6472 (4.3-specific) listUsageRecords:
Pull information from removed items as well,
fixing NPEs/Null UUIDs with usage API calls.
Posted by Sebastien Goasguen <ru...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21088/#review42274
-----------------------------------------------------------
Ship it!
thanks for the patch, you can close the review as submitted
- Sebastien Goasguen
On May 5, 2014, 9:44 p.m., Sam Schmit wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/21088/
> -----------------------------------------------------------
>
> (Updated May 5, 2014, 9:44 p.m.)
>
>
> Review request for cloudstack.
>
>
> Bugs: CLOUDSTACK-6472
> https://issues.apache.org/jira/browse/CLOUDSTACK-6472
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> Running "listUsageRecords" when there were any destroyed/expunged Virtual Machines would return errors (on 4.3) or return null UUIDs (on master). The UUID is important for correlating records.
>
>
> Diffs
> -----
>
> server/src/com/cloud/api/ApiResponseHelper.java a8bef47
> utils/src/com/cloud/utils/db/EntityManager.java d613d7d
>
> Diff: https://reviews.apache.org/r/21088/diff/
>
>
> Testing
> -------
>
> 1) Created virtual machine
> 2) Ran usage
> 3) ran "listUsageRecords" API call, successful data returned
> 4) Expunged VM
> 5) Ran usage
> 6) ran "listUsageRecords" API call, successful data returned (this would previously return an error)
>
>
> Thanks,
>
> Sam Schmit
>
>