You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@kyuubi.apache.org by "QianyongY (via GitHub)" <gi...@apache.org> on 2023/06/29 10:30:37 UTC
[GitHub] [kyuubi] QianyongY opened a new pull request, #5006: [KYUUBI #5005] Remove default settings `spark.sql.execution.topKSortFallbackThreshold`
QianyongY opened a new pull request, #5006:
URL: https://github.com/apache/kyuubi/pull/5006
### _Why are the changes needed?_
close #5005
### _How was this patch tested?_
- [ ] Add some test cases that check the changes thoroughly including negative and positive cases if possible
- [ ] Add screenshots for manual tests if appropriate
- [ ] [Run test](https://kyuubi.readthedocs.io/en/master/contributing/code/testing.html#running-tests) locally before make a pull request
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [kyuubi] codecov-commenter commented on pull request #5006: [KYUUBI #5005] Remove default settings `spark.sql.execution.topKSortFallbackThreshold`
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #5006:
URL: https://github.com/apache/kyuubi/pull/5006#issuecomment-1613009443
## [Codecov](https://app.codecov.io/gh/apache/kyuubi/pull/5006?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
> Merging [#5006](https://app.codecov.io/gh/apache/kyuubi/pull/5006?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (3bc8b74) into [master](https://app.codecov.io/gh/apache/kyuubi/commit/f8ee58f7d6045fd6569924353a28b2e0c602af36?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (f8ee58f) will **not change** coverage.
> The diff coverage is `n/a`.
```diff
@@ Coverage Diff @@
## master #5006 +/- ##
======================================
Coverage 0.00% 0.00%
======================================
Files 563 563
Lines 31168 31167 -1
Branches 4070 4070
======================================
+ Misses 31168 31167 -1
```
| [Impacted Files](https://app.codecov.io/gh/apache/kyuubi/pull/5006?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...rg/apache/kyuubi/engine/spark/SparkSQLEngine.scala](https://app.codecov.io/gh/apache/kyuubi/pull/5006?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-ZXh0ZXJuYWxzL2t5dXViaS1zcGFyay1zcWwtZW5naW5lL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUva3l1dWJpL2VuZ2luZS9zcGFyay9TcGFya1NRTEVuZ2luZS5zY2FsYQ==) | `0.00% <ø> (ø)` | |
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [kyuubi] turboFei closed pull request #5006: [KYUUBI #5005] Remove default settings `spark.sql.execution.topKSortFallbackThreshold`
Posted by "turboFei (via GitHub)" <gi...@apache.org>.
turboFei closed pull request #5006: [KYUUBI #5005] Remove default settings `spark.sql.execution.topKSortFallbackThreshold`
URL: https://github.com/apache/kyuubi/pull/5006
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [kyuubi] turboFei commented on pull request #5006: [KYUUBI #5005] Remove default settings `spark.sql.execution.topKSortFallbackThreshold`
Posted by "turboFei (via GitHub)" <gi...@apache.org>.
turboFei commented on PR #5006:
URL: https://github.com/apache/kyuubi/pull/5006#issuecomment-1613941836
thanks, merged to 1.7.2
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org