You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@trafficcontrol.apache.org by GitBox <gi...@apache.org> on 2020/11/04 21:11:29 UTC

[GitHub] [trafficcontrol] ocket8888 opened a new pull request #5246: Fix GHA running when title changed

ocket8888 opened a new pull request #5246:
URL: https://github.com/apache/trafficcontrol/pull/5246


   ## What does this PR (Pull Request) do?
   - [x] This PR fixes is not related to any Issue
   
   This PR fixes the GHA behavior where all checks would re-run when editing only PR metadata - the title or description. The downside to this is that the same trigger that fires when those events occur is also responsible for changes in the base branch of a PR. So from now on if you change the branch into which your PR goes (e.g. 4.1.x -> master) then you'll need to re-run the actions manually, if applicable. I do think that case is much less common, though.
   
   This also disables running actions against PRs in draft mode.
   
   ## Which Traffic Control components are affected by this PR?
   - CI tests
   
   ## What is the best way to verify this PR?
   I'm gonna change the PR's title after actions are done running, and you should be able to look through the action history to see that they only ran once (unless I messed something up and have to push more than the initial commit).
   
   ## If this is a bug fix, what versions of Traffic Control are affected?
   - master
   - 5.0.0 (RC1)
   
   ## The following criteria are ALL met by this PR
   - [x] This PR modifies testing automation
   - [x] Documentation is unnecessary
   - [x] An update to CHANGELOG.md is not necessary
   - [x] This PR includes any and all required license headers
   - [x] This PR **DOES NOT FIX A SERIOUS SECURITY VULNERABILITY**


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [trafficcontrol] zrhoffman merged pull request #5246: Fix GHA running when PR title or description changed

Posted by GitBox <gi...@apache.org>.
zrhoffman merged pull request #5246:
URL: https://github.com/apache/trafficcontrol/pull/5246


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org