[GitHub] [spark] nchammas commented on a change in pull request #34655: [SPARK-37380][PYTHON] Miscellaneous Python lint infra cleanup

[GitBox <gi...@apache.org>]

nchammas commented on a change in pull request #34655:
URL: https://github.com/apache/spark/pull/34655#discussion_r752775008



##########
File path: dev/lint-python
##########
@@ -275,8 +275,7 @@ SPARK_ROOT_DIR="$(dirname "${SCRIPT_DIR}")"
 
 pushd "$SPARK_ROOT_DIR" &> /dev/null
 
-# skipping local ruby bundle directory from the search
-PYTHON_SOURCE="$(find . -path ./docs/.local_ruby_bundle -prune -false -o -name "*.py")"
+PYTHON_SOURCE="$(git ls-files '*.py')"

Review comment:
       This is an improvement, but I don't think this is that great, either. In general, I don't like that we are building a huge string of every Python file and passing it as an argument.
   
   Instead, we should be using the appropriate include and exclude filters (e.g. via tox.ini) to capture everything to be tested. But I don't want to get into that here.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org